update checking target and execution condition

Author: sivchari

.golangci.example.yml

@@ -616,6 +616,9 @@ linters-settings:
   tenv:
     # The following configurations enable checks prior to Go 1.17.
     force: false
+    # The all option will run against all method in test file.
+    # By default, only methods that take *testing.T, *testing.B, and testing.TB as arguments are checked.
+    all: false
 
   unparam:
     # Inspect exported functions, default is false. Set to true if no external program/library imports your code.

go.mod

@@ -68,7 +68,7 @@ require (
 	github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c
 	github.com/shirou/gopsutil/v3 v3.21.8
 	github.com/sirupsen/logrus v1.8.1
-	github.com/sivchari/tenv v1.0.5
+	github.com/sivchari/tenv v1.1.6
 	github.com/sonatard/noctx v0.0.1
 	github.com/sourcegraph/go-diff v0.6.1
 	github.com/spf13/cobra v1.2.1

go.sum

@@ -456,6 +456,7 @@ type ThelperSettings struct {
 
 type TenvSettings struct {
 	Force bool `mapstructure:"force"`
+	All   bool `mapstructure:"all"`
 }
 
 type UnparamSettings struct {

pkg/config/linters_settings.go

@@ -20,6 +20,7 @@ func NewTenv(settings *config.TenvSettings) *goanalysis.Linter {
 		cfg = map[string]map[string]interface{}{
 			a.Name: {
 				tenv.F: settings.Force,
+				tenv.A: settings.All,
 			},
 		}
 	}

pkg/golinters/tenv.go

@@ -0,0 +1,4 @@
+linters-settings:
+  tenv:
+    force: true
+    all: true

test/testdata/configs/tenv_all_force.yml

@@ -0,0 +1,41 @@
+// args: -Etenv
+// config_path: testdata/configs/tenv_all_force.yml
+package testdata
+
+import (
+	"os"
+	"testing"
+)
+
+var (
+	e = os.Setenv("a", "b") // ERROR "variable e is not using testing.Setenv"
+)
+
+func setup() {
+	os.Setenv("a", "b")        // ERROR "func setup is not using testing.Setenv"
+	err := os.Setenv("a", "b") // ERROR "func setup is not using testing.Setenv"
+	if err != nil {
+		_ = err
+	}
+}
+
+func TestF(t *testing.T) {
+	os.Setenv("a", "b")                         // ERROR "func TestF is not using testing.Setenv"
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "func TestF is not using testing.Setenv"
+		_ = err
+	}
+}
+
+func BenchmarkF(b *testing.B) {
+	os.Setenv("a", "b")                         // ERROR "func BenchmarkF is not using testing.Setenv"
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "func BenchmarkF is not using testing.Setenv"
+		_ = err
+	}
+}
+
+func testTB(tb testing.TB) {
+	os.Setenv("a", "b")                         // ERROR "func testTB is not using testing.Setenv"
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "func testTB is not using testing.Setenv"
+		_ = err
+	}
+}

test/testdata/configs/tenv.yml test/testdata/configs/tenv_force.yml

@@ -1,8 +1,10 @@
 // args: -Etenv
+// config_path: testdata/configs/tenv_force.yml
 package testdata
 
 import (
 	"os"
+	"testing"
 )
 
 var (
@@ -17,9 +19,23 @@ func setup() {
 	}
 }
 
-func TestF() {
-	os.Setenv("a", "b")                         // OK
-	if err := os.Setenv("a", "b"); err != nil { // OK
+func TestF(t *testing.T) {
+	os.Setenv("a", "b")                         // ERROR "func TestF is not using testing.Setenv"
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "func TestF is not using testing.Setenv"
+		_ = err
+	}
+}
+
+func BenchmarkF(b *testing.B) {
+	os.Setenv("a", "b")                         // ERROR "func BenchmarkF is not using testing.Setenv"
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "func BenchmarkF is not using testing.Setenv"
+		_ = err
+	}
+}
+
+func testTB(tb testing.TB) {
+	os.Setenv("a", "b")                         // ERROR "func testTB is not using testing.Setenv"
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "func testTB is not using testing.Setenv"
 		_ = err
 	}
 }

test/testdata/tenv_all_force_test.go

@@ -1,26 +1,40 @@
 // args: -Etenv
-// config_path: testdata/configs/tenv.yml
 package testdata
 
 import (
 	"os"
+	"testing"
 )
 
 var (
-	e = os.Setenv("a", "b") // ERROR "variable e is not using t.Setenv"
+	e = os.Setenv("a", "b") // OK
 )
 
 func setup() {
-	os.Setenv("a", "b")        // ERROR "func setup is not using t.Setenv"
-	err := os.Setenv("a", "b") // ERROR "func setup is not using t.Setenv"
+	os.Setenv("a", "b")        // OK
+	err := os.Setenv("a", "b") // OK
 	if err != nil {
 		_ = err
 	}
 }
 
-func TestF() {
-	os.Setenv("a", "b")                         // ERROR "func TestF is not using t.Setenv"
-	if err := os.Setenv("a", "b"); err != nil { // ERROR "func TestF is not using t.Setenv"
+func TestF(t *testing.T) {
+	os.Setenv("a", "b")                         // OK
+	if err := os.Setenv("a", "b"); err != nil { // OK
+		_ = err
+	}
+}
+
+func BenchmarkF(b *testing.B) {
+	os.Setenv("a", "b")                         // OK
+	if err := os.Setenv("a", "b"); err != nil { // OK
+		_ = err
+	}
+}
+
+func testTB(tb testing.TB) {
+	os.Setenv("a", "b")                         // OK
+	if err := os.Setenv("a", "b"); err != nil { // OK
 		_ = err
 	}
 }