From cd41bd1a67c4095be35eba96810a72b2caf58501 Mon Sep 17 00:00:00 2001 From: "Hana (Hyang-Ah) Kim" Date: Thu, 27 Aug 2020 13:42:58 -0400 Subject: [PATCH] .github/workflows, build: install dlv in containers Tests now require dlv Change-Id: I3e144cb08938c98f661b480772bd62bdc971ea24 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/251084 Reviewed-by: Robert Findley --- .github/workflows/release-nightly.yml | 1 + .github/workflows/test-long.yml | 1 + .github/workflows/test-smoke.yml | 1 + build/Dockerfile | 3 ++- 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release-nightly.yml b/.github/workflows/release-nightly.yml index a05e999e36..bb2fc2191f 100644 --- a/.github/workflows/release-nightly.yml +++ b/.github/workflows/release-nightly.yml @@ -58,6 +58,7 @@ jobs: go get github.com/cweill/gotests/... go get github.com/rogpeppe/godef go get github.com/ramya-rao-a/go-outline + go get github.com/go-delve/delve/cmd/dlv env: GO111MODULE: on diff --git a/.github/workflows/test-long.yml b/.github/workflows/test-long.yml index bd4d631ba4..ca0bcd5224 100644 --- a/.github/workflows/test-long.yml +++ b/.github/workflows/test-long.yml @@ -57,6 +57,7 @@ jobs: go get github.com/cweill/gotests/... go get github.com/rogpeppe/godef go get github.com/ramya-rao-a/go-outline + go get github.com/go-delve/delve/cmd/dlv env: GO111MODULE: on diff --git a/.github/workflows/test-smoke.yml b/.github/workflows/test-smoke.yml index 6a1d2c767b..fb12a334f1 100644 --- a/.github/workflows/test-smoke.yml +++ b/.github/workflows/test-smoke.yml @@ -53,6 +53,7 @@ jobs: go get github.com/cweill/gotests/... go get github.com/rogpeppe/godef go get github.com/ramya-rao-a/go-outline + go get github.com/go-delve/delve/cmd/dlv env: GO111MODULE: on diff --git a/build/Dockerfile b/build/Dockerfile index b9cc9f6cd0..bebc26accd 100644 --- a/build/Dockerfile +++ b/build/Dockerfile @@ -32,7 +32,8 @@ RUN GO111MODULE=on go get -x -v github.com/acroca/go-symbols && \ GO111MODULE=on go get -x -v github.com/uudashr/gopkgs/v2/cmd/gopkgs && \ GO111MODULE=on go get -x -v github.com/zmb3/gogetdoc && \ GO111MODULE=on go get -x -v golang.org/x/lint/golint && \ - GO111MODULE=on go get -x -v golang.org/x/tools/cmd/gorename + GO111MODULE=on go get -x -v golang.org/x/tools/cmd/gorename && \ + GO111MODULE=on go get -x -v github.com/go-delve/delve/cmd/dlv WORKDIR /workspace ENTRYPOINT ["build/all.bash"]