From 11c692eb24abb64933c12b8f1b1ef7f4768a806e Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Thu, 4 Apr 2024 17:10:12 -0400 Subject: [PATCH] gopls/internal/test/marker/testdata: skip hover size tests on 32-bit arm Fixes golang/go#66686 Change-Id: I74388fa8788ff6893146e3ca0cdfccfd28275625 Reviewed-on: https://go-review.googlesource.com/c/tools/+/576657 Reviewed-by: Dmitri Shuralyov Reviewed-by: Dmitri Shuralyov LUCI-TryBot-Result: Go LUCI Auto-Submit: Alan Donovan --- gopls/internal/test/marker/testdata/definition/embed.txt | 2 +- gopls/internal/test/marker/testdata/definition/misc.txt | 2 +- gopls/internal/test/marker/testdata/hover/sizeoffset.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gopls/internal/test/marker/testdata/definition/embed.txt b/gopls/internal/test/marker/testdata/definition/embed.txt index a9b5c67fdc7..4bda1d71ebc 100644 --- a/gopls/internal/test/marker/testdata/definition/embed.txt +++ b/gopls/internal/test/marker/testdata/definition/embed.txt @@ -4,7 +4,7 @@ Its size expectations assume a 64-bit machine, and correct sizes information requires go1.21. -- flags -- --skip_goarch=386 +-skip_goarch=386,arm -min_go=go1.21 -- go.mod -- diff --git a/gopls/internal/test/marker/testdata/definition/misc.txt b/gopls/internal/test/marker/testdata/definition/misc.txt index ee37a55d295..7c6bc27f316 100644 --- a/gopls/internal/test/marker/testdata/definition/misc.txt +++ b/gopls/internal/test/marker/testdata/definition/misc.txt @@ -8,7 +8,7 @@ module mod.com go 1.16 -- flags -- --skip_goarch=386 +-skip_goarch=386,arm -- a.go -- package a //@loc(aPackage, re"package (a)"),hover(aPackage, aPackage, aPackage) diff --git a/gopls/internal/test/marker/testdata/hover/sizeoffset.txt b/gopls/internal/test/marker/testdata/hover/sizeoffset.txt index 86c33baf8c9..62f3b76dd60 100644 --- a/gopls/internal/test/marker/testdata/hover/sizeoffset.txt +++ b/gopls/internal/test/marker/testdata/hover/sizeoffset.txt @@ -10,7 +10,7 @@ Notes: - requires go1.22 because size information was inaccurate before. -- flags -- --skip_goarch=386 +-skip_goarch=386,arm -min_go=go1.22 -- go.mod --