Skip to content

Commit 795e854

Browse files
cuishuanggopherbot
authored andcommitted
all: replace io/ioutil with io and os package
For golang/go#45557 Change-Id: Ibf78d87cc94baa0d1696e5abc2edad3d2723e42b GitHub-Last-Rev: ad314ca GitHub-Pull-Request: #34 Reviewed-on: https://go-review.googlesource.com/c/text/+/430815 Reviewed-by: Cherry Mui <cherryyz@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Meng Zhuo <mzh@golangcn.org> Run-TryBot: Ian Lance Taylor <iant@google.com> Run-TryBot: Meng Zhuo <mzh@golangcn.org> Auto-Submit: Ian Lance Taylor <iant@google.com>
1 parent b0ca10f commit 795e854

File tree

21 files changed

+56
-69
lines changed

21 files changed

+56
-69
lines changed

cases/gen.go

+3-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import (
1616
"bytes"
1717
"fmt"
1818
"io"
19-
"io/ioutil"
2019
"log"
2120
"reflect"
2221
"strconv"
@@ -635,9 +634,9 @@ func genTablesTest() {
635634

636635
// We discard the output as we know we have perfect functions. We run them
637636
// just to verify the properties are correct.
638-
n := printProperties(ioutil.Discard, "DerivedCoreProperties.txt", "Cased", verifyCased)
639-
n += printProperties(ioutil.Discard, "DerivedCoreProperties.txt", "Lowercase", verifyLower)
640-
n += printProperties(ioutil.Discard, "DerivedCoreProperties.txt", "Uppercase", verifyUpper)
637+
n := printProperties(io.Discard, "DerivedCoreProperties.txt", "Cased", verifyCased)
638+
n += printProperties(io.Discard, "DerivedCoreProperties.txt", "Lowercase", verifyLower)
639+
n += printProperties(io.Discard, "DerivedCoreProperties.txt", "Uppercase", verifyUpper)
641640
if n > 0 {
642641
log.Fatalf("One of the discarded properties does not have a perfect filter.")
643642
}

cmd/gotext/main.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import (
1616
"go/build"
1717
"go/format"
1818
"io"
19-
"io/ioutil"
2019
"log"
2120
"os"
2221
"strings"
@@ -310,7 +309,7 @@ func help(args []string) {
310309
if err != nil {
311310
logf("Could not format generated docs: %v\n", err)
312311
}
313-
if err := ioutil.WriteFile("doc.go", b, 0666); err != nil {
312+
if err := os.WriteFile("doc.go", b, 0666); err != nil {
314313
logf("Could not create file alldocs.go: %v\n", err)
315314
}
316315
} else {

collate/maketables.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717
"flag"
1818
"fmt"
1919
"io"
20-
"io/ioutil"
2120
"log"
2221
"os"
2322
"regexp"
@@ -187,7 +186,7 @@ func failOnError(e error) {
187186

188187
func openArchive() *zip.Reader {
189188
f := gen.OpenCLDRCoreZip()
190-
buffer, err := ioutil.ReadAll(f)
189+
buffer, err := io.ReadAll(f)
191190
f.Close()
192191
failOnError(err)
193192
archive, err := zip.NewReader(bytes.NewReader(buffer), int64(len(buffer)))

collate/reg_test.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import (
1010
"bytes"
1111
"flag"
1212
"io"
13-
"io/ioutil"
1413
"log"
1514
"path"
1615
"regexp"
@@ -133,7 +132,7 @@ func convHex(line int, s string) int {
133132

134133
func loadTestData() []Test {
135134
f := gen.OpenUnicodeFile("UCA", "", "CollationTest.zip")
136-
buffer, err := ioutil.ReadAll(f)
135+
buffer, err := io.ReadAll(f)
137136
f.Close()
138137
Error(err)
139138
archive, err := zip.NewReader(bytes.NewReader(buffer), int64(len(buffer)))

encoding/encoding_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
package encoding_test
66

77
import (
8-
"io/ioutil"
8+
"io"
99
"strings"
1010
"testing"
1111

@@ -62,7 +62,7 @@ func TestReplacement(t *testing.T) {
6262
want = "AB\x00CD\ufffdYZ"
6363
}
6464
sr := strings.NewReader("AB\x00CD\x80YZ")
65-
g, err := ioutil.ReadAll(transform.NewReader(sr, enc))
65+
g, err := io.ReadAll(transform.NewReader(sr, enc))
6666
if err != nil {
6767
t.Errorf("%s: ReadAll: %v", direction, err)
6868
continue

encoding/internal/enctest/enctest.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"bytes"
99
"fmt"
1010
"io"
11-
"io/ioutil"
11+
"os"
1212
"strings"
1313
"testing"
1414

@@ -105,7 +105,7 @@ func Benchmark(b *testing.B, enc encoding.Encoding) {
105105
b.ResetTimer()
106106
for i := 0; i < b.N; i++ {
107107
r := transform.NewReader(bytes.NewReader(src), transformer)
108-
io.Copy(ioutil.Discard, r)
108+
io.Copy(io.Discard, r)
109109
}
110110
})
111111
}
@@ -157,15 +157,15 @@ func load(direction string, enc encoding.Encoding) ([]byte, []byte, Transcoder,
157157
dstFile, srcFile = srcFile, dstFile
158158
coder = enc.NewDecoder()
159159
}
160-
dst, err := ioutil.ReadFile(dstFile)
160+
dst, err := os.ReadFile(dstFile)
161161
if err != nil {
162-
if dst, err = ioutil.ReadFile("../" + dstFile); err != nil {
162+
if dst, err = os.ReadFile("../" + dstFile); err != nil {
163163
return nil, nil, nil, err
164164
}
165165
}
166-
src, err := ioutil.ReadFile(srcFile)
166+
src, err := os.ReadFile(srcFile)
167167
if err != nil {
168-
if src, err = ioutil.ReadFile("../" + srcFile); err != nil {
168+
if src, err = os.ReadFile("../" + srcFile); err != nil {
169169
return nil, nil, nil, err
170170
}
171171
}

encoding/traditionalchinese/all_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ package traditionalchinese
66

77
import (
88
"fmt"
9-
"io/ioutil"
9+
"io"
1010
"strings"
1111
"testing"
1212

@@ -103,7 +103,7 @@ func TestBig5CircumflexAndMacron(t *testing.T) {
103103
"\x88\xa2\x88\xa3\x88\xa4\x88\xa5\x88\xa6"
104104
want := "ÓǑÒ\u00ca\u0304\u00ca\u030cỀÊ " +
105105
\u00ea\u0304ế\u00ea\u030cề"
106-
dst, err := ioutil.ReadAll(transform.NewReader(
106+
dst, err := io.ReadAll(transform.NewReader(
107107
strings.NewReader(src), Big5.NewDecoder()))
108108
if err != nil {
109109
t.Fatal(err)

feature/plural/message.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ package plural
66

77
import (
88
"fmt"
9-
"io/ioutil"
9+
"io"
1010
"reflect"
1111
"strconv"
1212

@@ -56,7 +56,7 @@ type Interface interface {
5656
func Selectf(arg int, format string, cases ...interface{}) catalog.Message {
5757
var p parser
5858
// Intercept the formatting parameters of format by doing a dummy print.
59-
fmt.Fprintf(ioutil.Discard, format, &p)
59+
fmt.Fprintf(io.Discard, format, &p)
6060
m := &message{arg, kindDefault, 0, cases}
6161
switch p.verb {
6262
case 'g':

gen.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import (
1414
"flag"
1515
"fmt"
1616
"go/format"
17-
"io/ioutil"
1817
"os"
1918
"os/exec"
2019
"path"
@@ -256,7 +255,7 @@ func copyPackage(dirSrc, dirDst, search, replace string) {
256255
filepath.Dir(file) != dirSrc {
257256
return nil
258257
}
259-
b, err := ioutil.ReadFile(file)
258+
b, err := os.ReadFile(file)
260259
if err != nil || bytes.Contains(b, []byte("\n// +build ignore")) {
261260
return err
262261
}
@@ -275,7 +274,7 @@ func copyPackage(dirSrc, dirDst, search, replace string) {
275274
}
276275
file = filepath.Join(dirDst, base)
277276
vprintf("=== COPY %s\n", file)
278-
return ioutil.WriteFile(file, b, 0666)
277+
return os.WriteFile(file, b, 0666)
279278
})
280279
if err != nil {
281280
fmt.Println("Copying exported files failed:", err)

internal/cldrtree/cldrtree_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ package cldrtree
77
import (
88
"bytes"
99
"flag"
10-
"io/ioutil"
1110
"log"
1211
"math/rand"
12+
"os"
1313
"path/filepath"
1414
"reflect"
1515
"regexp"
@@ -303,11 +303,11 @@ func TestGen(t *testing.T) {
303303

304304
file := filepath.Join("testdata", tc, "output.go")
305305
if *genOutput {
306-
ioutil.WriteFile(file, got, 0700)
306+
os.WriteFile(file, got, 0700)
307307
t.SkipNow()
308308
}
309309

310-
b, err := ioutil.ReadFile(file)
310+
b, err := os.ReadFile(file)
311311
if err != nil {
312312
t.Fatalf("failed to open file: %v", err)
313313
}

internal/gen/bitfield/bitfield_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ package bitfield
77
import (
88
"bytes"
99
"fmt"
10-
"io/ioutil"
10+
"os"
1111
"testing"
1212
)
1313

@@ -222,7 +222,7 @@ func (t test1) Baz() int8 {
222222
`
223223

224224
func mustRead(filename string) string {
225-
b, err := ioutil.ReadFile(filename)
225+
b, err := os.ReadFile(filename)
226226
if err != nil {
227227
panic(err)
228228
}

internal/gen/gen.go

+7-8
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import (
2525
"go/build"
2626
"go/format"
2727
"io"
28-
"io/ioutil"
2928
"log"
3029
"net/http"
3130
"os"
@@ -175,7 +174,7 @@ func getLocalDir() string {
175174
if err := os.MkdirAll(dir, permissions); err != nil {
176175
log.Fatalf("Could not create directory: %v", err)
177176
}
178-
ioutil.WriteFile(readme, []byte(readmeTxt), permissions)
177+
os.WriteFile(readme, []byte(readmeTxt), permissions)
179178
}
180179
return dir
181180
}
@@ -213,15 +212,15 @@ func open(file, urlRoot, path string) io.ReadCloser {
213212
}
214213
r := get(urlRoot, path)
215214
defer r.Close()
216-
b, err := ioutil.ReadAll(r)
215+
b, err := io.ReadAll(r)
217216
if err != nil {
218217
log.Fatalf("Could not download file: %v", err)
219218
}
220219
os.MkdirAll(filepath.Dir(file), permissions)
221-
if err := ioutil.WriteFile(file, b, permissions); err != nil {
220+
if err := os.WriteFile(file, b, permissions); err != nil {
222221
log.Fatalf("Could not create file: %v", err)
223222
}
224-
return ioutil.NopCloser(bytes.NewReader(b))
223+
return io.NopCloser(bytes.NewReader(b))
225224
}
226225

227226
func get(root, path string) io.ReadCloser {
@@ -280,13 +279,13 @@ func fileToPattern(filename string) string {
280279
func updateBuildTags(pattern string) {
281280
for _, t := range tags {
282281
oldFile := fmt.Sprintf(pattern, t.version)
283-
b, err := ioutil.ReadFile(oldFile)
282+
b, err := os.ReadFile(oldFile)
284283
if err != nil {
285284
continue
286285
}
287286
build := fmt.Sprintf("// +build %s", t.buildTags)
288287
b = regexp.MustCompile(`// \+build .*`).ReplaceAll(b, []byte(build))
289-
err = ioutil.WriteFile(oldFile, b, 0644)
288+
err = os.WriteFile(oldFile, b, 0644)
290289
if err != nil {
291290
log.Fatal(err)
292291
}
@@ -334,7 +333,7 @@ func WriteGo(w io.Writer, pkg, tags string, b []byte) (n int, err error) {
334333
// Repackage rewrites a Go file from belonging to package main to belonging to
335334
// the given package.
336335
func Repackage(inFile, outFile, pkg string) {
337-
src, err := ioutil.ReadFile(inFile)
336+
src, err := os.ReadFile(inFile)
338337
if err != nil {
339338
log.Fatalf("reading %s: %v", inFile, err)
340339
}

internal/language/gen.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515
"flag"
1616
"fmt"
1717
"io"
18-
"io/ioutil"
1918
"log"
2019
"math"
2120
"reflect"
@@ -921,7 +920,7 @@ func (b *builder) writeRegion() {
921920
r := gen.OpenIANAFile("domains/root/db")
922921
defer r.Close()
923922

924-
buf, err := ioutil.ReadAll(r)
923+
buf, err := io.ReadAll(r)
925924
failOnError(err)
926925
re := regexp.MustCompile(`"/domains/root/db/([a-z]{2}).html"`)
927926
for _, m := range re.FindAllSubmatch(buf, -1) {

internal/testtext/codesize.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ package testtext
77
import (
88
"bytes"
99
"fmt"
10-
"io/ioutil"
1110
"os"
1211
"os/exec"
1312
"path/filepath"
@@ -26,13 +25,13 @@ import (
2625
// See dict_test.go in the display package for an example.
2726
func CodeSize(s string) (int, error) {
2827
// Write the file.
29-
tmpdir, err := ioutil.TempDir(os.TempDir(), "testtext")
28+
tmpdir, err := os.MkdirTemp(os.TempDir(), "testtext")
3029
if err != nil {
3130
return 0, fmt.Errorf("testtext: failed to create tmpdir: %v", err)
3231
}
3332
defer os.RemoveAll(tmpdir)
3433
filename := filepath.Join(tmpdir, "main.go")
35-
if err := ioutil.WriteFile(filename, []byte(s), 0644); err != nil {
34+
if err := os.WriteFile(filename, []byte(s), 0644); err != nil {
3635
return 0, fmt.Errorf("testtext: failed to write main.go: %v", err)
3736
}
3837

internal/triegen/example_compact_test.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ package triegen_test
77
import (
88
"fmt"
99
"io"
10-
"io/ioutil"
1110

1211
"golang.org/x/text/internal/triegen"
1312
)
@@ -17,12 +16,12 @@ func ExampleCompacter() {
1716
for r := rune(0); r < 10000; r += 64 {
1817
t.Insert(r, 0x9015BADA55^uint64(r))
1918
}
20-
sz, _ := t.Gen(ioutil.Discard)
19+
sz, _ := t.Gen(io.Discard)
2120

2221
fmt.Printf("Size normal: %5d\n", sz)
2322

2423
var c myCompacter
25-
sz, _ = t.Gen(ioutil.Discard, triegen.Compact(&c))
24+
sz, _ = t.Gen(io.Discard, triegen.Compact(&c))
2625

2726
fmt.Printf("Size compacted: %5d\n", sz)
2827

internal/triegen/example_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ package triegen_test
66

77
import (
88
"fmt"
9-
"io/ioutil"
9+
"io"
1010
"math/rand"
1111
"unicode"
1212

@@ -15,7 +15,7 @@ import (
1515

1616
const seed = 0x12345
1717

18-
var genWriter = ioutil.Discard
18+
var genWriter = io.Discard
1919

2020
func randomRunes() map[rune]uint8 {
2121
rnd := rand.New(rand.NewSource(seed))

0 commit comments

Comments
 (0)