-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no more generated package doc #528
Conversation
\cc @neild. We were discussing just removing this all together. |
The package doc comment is pretty useless at the moment. I can see a case for just removing it. I don't really have a strong opinion one way or the other, although I think I'd rather get rid of it always than add another knob. |
@neild, how does it look now? |
2bba5d3
to
1724048
Compare
1724048
to
302ab30
Compare
+1 to getting rid of this |
CL looks fine to me, I'll leave it up to @dsnet to decide whether we actually want to do this or not. |
I vote to remove it as well. As it currently stands, it:
|
This would resolve #413. It relies on a flag that can be passed to protoc-gen-go.