Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/websocket: websocket connections through HTTP proxies not supported #7182

Closed
gopherbot opened this issue Jan 22, 2014 · 6 comments
Closed

x/net/websocket: websocket connections through HTTP proxies not supported #7182

gopherbot opened this issue Jan 22, 2014 · 6 comments
Labels
FrozenDueToAge help wanted
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor

by aaron@hubernet.net:

What steps will reproduce the problem?
If possible, include a link to a program on play.golang.org.
1.  Use the websocket client to initiate a connection where an HTTP proxy is required.

What is the expected output?
Successful HTTP CONNECT is issued via the proxy server to the endpoint.

What do you see instead?
Connection is attempted directly and fails.

Current websocket code does not contain any logic to connect via an HTTP proxy server
which is supported by the WebSockets protocol.
@rsc
Copy link
Contributor

rsc commented Mar 3, 2014

Comment 1:

Labels changed: added repo-net.

@bradfitz bradfitz removed the new label Dec 18, 2014
@mikioh mikioh changed the title go.net/websocket: websocket connections through HTTP proxies not supported x/net/websocket: websocket connections through HTTP proxies not supported Dec 23, 2014
@mikioh mikioh added repo-net and removed repo-net labels Dec 23, 2014
@mikioh mikioh changed the title x/net/websocket: websocket connections through HTTP proxies not supported websocket: websocket connections through HTTP proxies not supported Jan 4, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc removed the release-none label Apr 10, 2015
@rsc rsc changed the title websocket: websocket connections through HTTP proxies not supported x/net/websocket: websocket connections through HTTP proxies not supported Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-net label Apr 14, 2015
@crazybits
Copy link

when to support http proxy in websocket?

@bradfitz
Copy link
Contributor

bradfitz commented Jun 5, 2017

@crazybits, no plans. Nobody is working on this. Feel free to work on it if you'd like.

@bradfitz
Copy link
Contributor

bradfitz commented Jun 5, 2017

The best answer might be to use https://github.com/gorilla/websocket instead.

@meirf
Copy link
Contributor

meirf commented Aug 12, 2018

Related: #26937

@odeke-em
Copy link
Member

So per x/net/websocket being frozen and no longer maintained, as Brad recommended, please check out packages:

which we recommend on the godoc for x/net/websocket

@golang golang locked and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
7 participants
@bradfitz @mikioh @rsc @meirf @odeke-em @crazybits @gopherbot