x/tools/gopls/internal/lsp/source: TestSource failures

[gopherbot]

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/source" && test == "TestSource"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestSource (205.10s)
    --- FAIL: TestSource/Modules (60.03s)
        --- FAIL: TestSource/Modules/Diagnostics (14.28s)
            --- FAIL: TestSource/Modules/Diagnostics/bad_test (0.04s)
                source_test.go:162: bad_test.go:9:0-9:0: unmatched diagnostic pattern "Testbad has malformed name: first letter after 'Test' must not be lowercase"
                source_test.go:162: bad_test.go:13:1-13:20: unmatched diagnostic pattern "golang.org/lsptests/analyzer.printfWrapper format %s reads arg #1, but call has 0 args"
                source_test.go:162: bad_test.go:22:25-22:35: unmatched diagnostic pattern "2006-02-01 should be 2006-01-02"
    --- FAIL: TestSource/GOPATH (67.67s)
        --- FAIL: TestSource/GOPATH/Diagnostics (0.90s)
            --- FAIL: TestSource/GOPATH/Diagnostics/bad_test (0.03s)
                source_test.go:162: bad_test.go:9:0-9:0: unmatched diagnostic pattern "Testbad has malformed name: first letter after 'Test' must not be lowercase"
                source_test.go:162: bad_test.go:13:1-13:20: unmatched diagnostic pattern "golang.org/lsptests/analyzer.printfWrapper format %s reads arg #1, but call has 0 args"
                source_test.go:162: bad_test.go:22:25-22:35: unmatched diagnostic pattern "2006-02-01 should be 2006-01-02"
    --- FAIL: TestSource/MultiModule (77.41s)
        --- FAIL: TestSource/MultiModule/Diagnostics (0.78s)
            --- FAIL: TestSource/MultiModule/Diagnostics/bad_test (0.01s)
                source_test.go:162: bad_test.go:9:0-9:0: unmatched diagnostic pattern "Testbad has malformed name: first letter after 'Test' must not be lowercase"
                source_test.go:162: bad_test.go:13:1-13:20: unmatched diagnostic pattern "golang.org/lsptests/analyzer.printfWrapper format %s reads arg #1, but call has 0 args"
                source_test.go:162: bad_test.go:22:25-22:35: unmatched diagnostic pattern "2006-02-01 should be 2006-01-02"

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/source" && test == "TestSource"

2023-01-06 17:06 darwin-amd64-12_0 tools@16b3bf8d go@eeaf508d x/tools/gopls/internal/lsp/source.TestSource (log)

--- FAIL: TestSource (205.10s)
    --- FAIL: TestSource/Modules (60.03s)
        --- FAIL: TestSource/Modules/Diagnostics (14.28s)
            --- FAIL: TestSource/Modules/Diagnostics/bad_test (0.04s)
                source_test.go:162: bad_test.go:9:0-9:0: unmatched diagnostic pattern "Testbad has malformed name: first letter after 'Test' must not be lowercase"
                source_test.go:162: bad_test.go:13:1-13:20: unmatched diagnostic pattern "golang.org/lsptests/analyzer.printfWrapper format %s reads arg #1, but call has 0 args"
                source_test.go:162: bad_test.go:22:25-22:35: unmatched diagnostic pattern "2006-02-01 should be 2006-01-02"
    --- FAIL: TestSource/GOPATH (67.67s)
        --- FAIL: TestSource/GOPATH/Diagnostics (0.90s)
            --- FAIL: TestSource/GOPATH/Diagnostics/bad_test (0.03s)
                source_test.go:162: bad_test.go:9:0-9:0: unmatched diagnostic pattern "Testbad has malformed name: first letter after 'Test' must not be lowercase"
                source_test.go:162: bad_test.go:13:1-13:20: unmatched diagnostic pattern "golang.org/lsptests/analyzer.printfWrapper format %s reads arg #1, but call has 0 args"
                source_test.go:162: bad_test.go:22:25-22:35: unmatched diagnostic pattern "2006-02-01 should be 2006-01-02"
    --- FAIL: TestSource/MultiModule (77.41s)
        --- FAIL: TestSource/MultiModule/Diagnostics (0.78s)
            --- FAIL: TestSource/MultiModule/Diagnostics/bad_test (0.01s)
                source_test.go:162: bad_test.go:9:0-9:0: unmatched diagnostic pattern "Testbad has malformed name: first letter after 'Test' must not be lowercase"
                source_test.go:162: bad_test.go:13:1-13:20: unmatched diagnostic pattern "golang.org/lsptests/analyzer.printfWrapper format %s reads arg #1, but call has 0 args"
                source_test.go:162: bad_test.go:22:25-22:35: unmatched diagnostic pattern "2006-02-01 should be 2006-01-02"

— watchflakes

[bcmills]

This test does not seem to meet the bar of https://go.dev/wiki/CodeReviewComments#useful-test-failures — the test logs indicate that an expected diagnostic pattern was not matched, but there isn't any information in the test log about what happened instead.

[findleyr]

Sadly, this is one of the LSP tests that I have already tried to improve (c.f. #54845). The test output does actually fully describe the delta between actual and expected: it is listing patterns that were expected an unmatched. The previous logic simply printed all expected and actual diagnostics, which made it hard to spot differences, and we have subsequently added support for regexp matching.

I can mail a CL that does something in-between, similar to the go/types tests.

[findleyr]

We're rewriting all of these tests in the new marker framework (gopls/internal/regtest/marker/testdata). I believe the new output for diagnostics is better.