x/tools/internal/lsp/source: test failures with diffs on "//@complete" lines #49463

bcmills · 2021-11-08T21:32:18Z

greplogs --dashboard -md -l -e \(\?m\)-.\*//@complete.\*\\n.\*\\+.\*\\\{\\}//@complete.\*\\n\(\?:.\*\\n\)\*FAIL\\s+golang.org/x/tools/internal/lsp/source

The text was updated successfully, but these errors were encountered:

bcmills · 2021-11-08T21:34:38Z

@findleyr, given the platforms involved I suspect that this may be a misreported crash in some subprocess.

FreeBSD may or may not still have memory corruption issues (#46272, #49347), and the plan9 builders are often on pretty shaky ground too.

hyangah · 2021-11-10T17:05:33Z

I checked a few recent logs and observed different failure patterns. I also think //@complete is a redherring (that's a part of trace that indicates gopls couldn't fix broken sources completely).

FreeBSD: subprocess killed?

2021-11-05T22:03:24-4ab7496-035963c/freebsd-amd64-race
2021-11-05T21:48:25-4ab7496-6b223e8/freebsd-amd64-race

signal: killed
FAIL	golang.org/x/tools/go/packages	192.661s
...
FAIL
:: Running /tmp/workdir/go/bin/go with args ["/tmp/workdir/go/bin/go" "test" "-short" "-race" "golang.org/x/tools/gopls/..."] and env ["PATH=/tmp/workdir/go/bin:/bin:/sbin:/usr/bin:/usr/local/bin" "PWD=/" "HOME=/" "RC_PID=36" "WORKDIR=/tmp/workdir" "GOROOT_BOOTSTRAP=/tmp/workdir/go1.4" "GO_BUILDER_NAME=freebsd-amd64-race" "GOROOT=/tmp/workdir/go" "GOPATH=/tmp/workdir/gopath" "GOPROXY=http://gk3-services-nap-yh2ma9qv-91853bd1-6dg1.c.symbolic-datum-552.internal:30157" "TMPDIR=/tmp/workdir/tmp" "GOCACHE=/tmp/workdir/gocache"] in dir /tmp/workdir/gopath/src/golang.org/x/tools/gopls

2021-11-04T23:35:26-6f75aad-256a8fc/freebsd-386-12_2
2021-11-01T13:54:03-42daa65-4a84298/freebsd-amd64-race

*** Test killed with quit: ran too long (11m0s).
FAIL	golang.org/x/tools/internal/lsp/source	660.046s

Plan9: difference in file system? Heavy use of t.Helper in gopls tests prevent me finding the exact failure location easily :-(

2021-11-08T14:49:56-0c60b7c-ab31dbc/plan9-386-0intro
2021-11-07T04:57:22-0c60b7c-9e6ad46/plan9-386-0intro
2021-11-04T17:07:48-84e69e7-5772877/plan9-386-0intro
2021-11-04T14:54:46-84e69e7-00d6d20/plan9-amd64-0intro
2021-11-04T07:05:31-84e69e7-2622235/plan9-386-0intro
2021-11-04T07:05:31-84e69e7-2622235/plan9-amd64-0intro

Combination of the following failures

--- FAIL: TestLSP (55.46s)
    --- FAIL: TestLSP/MultiModule (10.76s)
        lsp_test.go:35: rename /tmp/TestLSP_MultiModule3398047324/lsp/go.mod testmodule/go.mod: invalid argument
FAIL
FAIL	golang.org/x/tools/internal/lsp	55.513s

...
--- FAIL: TestSource (58.97s)
    --- FAIL: TestSource/MultiModule (9.00s)
        source_test.go:36: rename /tmp/TestSource_MultiModule231230237/lsp/go.mod testmodule/go.mod: invalid argument
FAIL
FAIL	golang.org/x/tools/internal/lsp/source	67.921s
...

--- FAIL: TestUnknownRevision (4.70s)
    --- FAIL: TestUnknownRevision/bad (0.80s)
        --- FAIL: TestUnknownRevision/bad/default (0.39s)
            --- FAIL: TestUnknownRevision/bad/default/singleton (0.39s)
                modfile_test.go:561: All files must be saved first (unsaved: [/tmp/gopls-regtest-2501435137/TestUnknownRevision/bad/default/singleton/work/a/go.mod]).
        --- FAIL: TestUnknownRevision/bad/nested (0.41s)
            --- FAIL: TestUnknownRevision/bad/nested/singleton (0.41s)
                modfile_test.go:561: All files must be saved first (unsaved: [/tmp/gopls-regtest-2501435137/TestUnknownRevision/bad/nested/singleton/work/a/go.mod]).
               
FAIL
FAIL	golang.org/x/tools/gopls/internal/regtest/modfile	37.297s

NetBSD: maybe tree was unstable back then?

2021-10-29T23:15:00-a2be0cd-8dfb447/netbsd-amd64-9_0
2021-10-29T21:19:39-a2be0cd-994049a/netbsd-amd64-9_0

*** Test killed with quit: ran too long (11m0s).
FAIL	golang.org/x/tools/internal/lsp/source	660.202s

But given the error like this occurred in a different test (stringer), not sure how stable the builder at the revision was.

mspan.sweep: state=1 sweepgen=9 mheap.sweepgen=10
fatal error: mspan.sweep: bad span state

goroutine 3 [running]:
runtime.throw({0x9b3efe?, 0x7f7ff7aa95d8?})
	/tmp/workdir/go/src/runtime/panic.go:992 +0x71 fp=0xc000045658 sp=0xc000045628 pc=0x4337f1
runtime.(*sweepLocked).sweep(0xd84e40?, 0x0?)
	/tmp/workdir/go/src/runtime/mgcsweep.go:486 +0xbbb fp=0xc000045740 sp=0xc000045658 pc=0x424cdb
runtime.sweepone()
	/tmp/workdir/go/src/runtime/mgcsweep.go:369 +0xf0 fp=0xc000045790 sp=0xc000045740 pc=0x423e50
runtime.bgsweep(0x0?)
	/tmp/workdir/go/src/runtime/mgcsweep.go:281 +0x105 fp=0xc0000457c8 sp=0xc000045790 pc=0x423c05
runtime.gcenable.func1()
	/tmp/workdir/go/src/runtime/mgc.go:177 +0x26 fp=0xc0000457e0 sp=0xc0000457c8 pc=0x419dc6
runtime.goexit()
	/tmp/workdir/go/src/runtime/asm_amd64.s:1446 +0x1 fp=0xc0000457e8 sp=0xc0000457e0 pc=0x4623c1
created by runtime.gcenable
	/tmp/workdir/go/src/runtime/mgc.go:177 +0x6b

or

fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0x280 pc=0x40c9ce]

goroutine 15044 [running]:
runtime.throw({0xaea372?, 0xc000048900?})
	/tmp/workdir/go/src/runtime/panic.go:965 +0x71 fp=0xc000c5d508 sp=0xc000c5d4d8 pc=0x435611
runtime.sigpanic()
	/tmp/workdir/go/src/runtime/signal_unix.go:781 +0x3a9 fp=0xc000c5d558 sp=0xc000c5d508 pc=0x44ba49
runtime.unlock2(0xbf07b0?)
	/tmp/workdir/go/src/runtime/lock_sema.go:115 +0x4e fp=0xc000c5d580 sp=0xc000c5d558 pc=0x40c9ce
runtime.unlockWithRank(...)
	/tmp/workdir/go/src/runtime/lockrank_off.go:31
runtime.unlock(...)
	/tmp/workdir/go/src/runtime/lock_sema.go:97
runtime.(*pollCache).free(0x104b2b0, 0x7f7ff7a8e310)
	/tmp/workdir/go/src/runtime/netpoll.go:199 +0x45 fp=0xc000c5d598 sp=0xc000c5d580 pc=0x431345
internal/poll.runtime_pollClose(0xc000c5d5f0?)
	/tmp/workdir/go/src/runtime/netpoll.go:192 +0x4e fp=0xc000c5d5b8 sp=0xc000c5d598 pc=0x4618ae
internal/poll.(*pollDesc).close(...)
	/tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:51
internal/poll.(*FD).destroy(0xc00ef25aa0)
	/tmp/workdir/go/src/internal/poll/fd_unix.go:76 +0x2e fp=0xc000c5d5e0 sp=0xc000c5d5b8 pc=0x498f6e
internal/poll.(*FD).decref(0x7f7ff7a8e310?)
	/tmp/workdir/go/src/internal/poll/fd_mutex.go:213 +0x53 fp=0xc000c5d600 sp=0xc000c5d5e0 pc=0x497df3
internal/poll.(*FD).Close(0xc00ef25aa0)
	/tmp/workdir/go/src/internal/poll/fd_unix.go:106 +0x4f fp=0xc000c5d628 sp=0xc000c5d600 pc=0x49902f
os.(*file).close(0xc00ef25aa0)
	/tmp/workdir/go/src/os/file_unix.go:252 +0xad fp=0xc000c5d680 sp=0xc000c5d628 pc=0x4a50ad
os.(*File).Close(0xc00bcba000?)
	/tmp/workdir/go/src/os/file_posix.go:25 +0x25 fp=0xc000c5d698 sp=0xc000c5d680 pc=0x4a3965
os/exec.(*Cmd).closeDescriptors(...)
	/tmp/workdir/go/src/os/exec/exec.go:320
os/exec.(*Cmd).Start(0xc00bcb02c0)
	/tmp/workdir/go/src/os/exec/exec.go:434 +0x843 fp=0xc000c5d870 sp=0xc000c5d698 pc=0x5499a3
golang.org/x/tools/internal/gocommand.runCmdContext({0xca3d70, 0xc00666b840}, 0xc00bcb02c0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:230 +0x46 fp=0xc000c5d918 sp=0xc000c5d870 pc=0x68da66
golang.org/x/tools/internal/gocommand.(*Invocation).run(0xc000aabbc0, {0xca3d70, 0xc00666b840}, {0xc9f740?, 0xc00bcb6450}, {0xc9f740?, 0xc00bcb6480})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:224 +0x104d fp=0xc000c5da40 sp=0xc000c5d918 pc=0x68d74d
golang.org/x/tools/internal/gocommand.(*Invocation).runWithFriendlyError(0xc000aabb88?, {0xca3d70, 0xc00666b840}, {0xc9f740?, 0xc00bcb6450?}, {0xc9f740?, 0xc00bcb6480?})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:146 +0x65 fp=0xc000c5daf0 sp=0xc000c5da40 pc=0x68c4e5
golang.org/x/tools/internal/gocommand.(*Runner).runConcurrent(0xc00b763ca0, {0xca3d70, 0xc00666b840}, {{0xab068e, 0x4}, {0xc00666ba40, 0x4, 0x4}, {0x104b060, 0x0, ...}, ...})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:97 +0x1e5 fp=0xc000c5dbc0 sp=0xc000c5daf0 pc=0x68be45
golang.org/x/tools/internal/gocommand.(*Runner).RunRaw(0x7f7fcc742de8?, {0xca3d70, 0xc00666b840}, {{0xab068e, 0x4}, {0xc00666ba40, 0x4, 0x4}, {0x104b060, 0x0, ...}, ...})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:72 +0x90 fp=0xc000c5dce8 sp=0xc000c5dbc0 pc=0x68ba50
golang.org/x/tools/go/internal/packagesdriver.GetSizesGolist({0xca3d70, 0xc00666b840}, {{0xab068e, 0x4}, {0xc00666ba40, 0x4, 0x4}, {0x104b060, 0x0, 0x0}, ...}, ...)
	/tmp/workdir/gopath/src/golang.org/x/tools/go/internal/packagesdriver/sizes.go:22 +0x11c fp=0xc000c5de50 sp=0xc000c5dce8 pc=0x805bbc
golang.org/x/tools/go/packages.goListDriver.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/go/packages/golist.go:157 +0x178 fp=0xc000c5dfe0 sp=0xc000c5de50 pc=0x819498
runtime.goexit()
	/tmp/workdir/go/src/runtime/asm_amd64.s:1446 +0x1 fp=0xc000c5dfe8 sp=0xc000c5dfe0 pc=0x466fa1
created by golang.org/x/tools/go/packages.goListDriver
	/tmp/workdir/gopath/src/golang.org/x/tools/go/packages/golist.go:155 +0x32a

findleyr · 2021-11-10T17:09:40Z

Thanks @hyangah for that investigation!

A few thoughts:

FAIL	golang.org/x/tools/internal/lsp/source	660.046s

This test is not particularly slow (8s on my desktop, IIRC). Such a timeout indicates a builder problem to me, or maybe a deadlock, but I would be surprised at the latter.

--- FAIL: TestUnknownRevision/bad/default/singleton (0.39s)
                modfile_test.go:561: All files must be saved first

This looks like a race.

bcmills · 2021-11-10T18:07:38Z

NetBSD: maybe tree was unstable back then?

Was and still is: those look like #49453 and/or #49209.

bcmills · 2021-11-10T18:09:16Z

(At a higher level: I suspect that we shouldn't dig too hard into this one until the runtime instability on the BSDs has been resolved.)

gopherbot · 2021-12-10T18:10:01Z

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

findleyr · 2021-12-10T18:11:48Z

The BSDs are still unstable recently, but we should not close this issue yet.

findleyr · 2023-11-10T16:56:29Z

These tests no longer exist.

gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 8, 2021

gopherbot added this to the Unreleased milestone Nov 8, 2021

bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 8, 2021

hyangah modified the milestones: Unreleased, gopls/unplanned Nov 10, 2021

bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 10, 2021

findleyr modified the milestones: gopls/unplanned, gopls/on-deck Dec 9, 2021

bcmills mentioned this issue Dec 9, 2021

openbsd: SIGSEGV via poll.runtime_pollClose #50082

Closed

gopherbot closed this as completed Dec 10, 2021

findleyr reopened this Dec 10, 2021

gopherbot closed this as completed Dec 10, 2021

bcmills reopened this Dec 10, 2021

bcmills added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Dec 10, 2021

gopherbot closed this as completed Jan 10, 2022

findleyr added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Jan 10, 2022

findleyr reopened this Jan 10, 2022

findleyr added the gopls/testing label Apr 11, 2022

findleyr added Testing An issue that has been verified to require only test changes, not just a test failure. and removed gopls/testing labels May 10, 2022

seankhliao removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Dec 26, 2022

findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2023

findleyr modified the milestones: gopls/backlog, gopls/unplanned May 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/internal/lsp/source: test failures with diffs on "//@complete" lines #49463

x/tools/internal/lsp/source: test failures with diffs on "//@complete" lines #49463

bcmills commented Nov 8, 2021

bcmills commented Nov 8, 2021

hyangah commented Nov 10, 2021

findleyr commented Nov 10, 2021

bcmills commented Nov 10, 2021

bcmills commented Nov 10, 2021

gopherbot commented Dec 10, 2021

findleyr commented Dec 10, 2021

findleyr commented Nov 10, 2023

x/tools/internal/lsp/source: test failures with diffs on "//@complete" lines #49463

x/tools/internal/lsp/source: test failures with diffs on "//@complete" lines #49463

Comments

bcmills commented Nov 8, 2021

bcmills commented Nov 8, 2021

hyangah commented Nov 10, 2021

findleyr commented Nov 10, 2021

bcmills commented Nov 10, 2021

bcmills commented Nov 10, 2021

gopherbot commented Dec 10, 2021

findleyr commented Dec 10, 2021

findleyr commented Nov 10, 2023