Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/api: omit vendored dependencies when run inside the 'std' module #41358

Closed
cherrymui opened this issue Sep 12, 2020 · 4 comments
Closed

cmd/api: omit vendored dependencies when run inside the 'std' module #41358

cherrymui opened this issue Sep 12, 2020 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.16

Comments

@cherrymui
Copy link
Member

What version of Go are you using (go version)?

tip (b459bc8)

Does this issue reproduce with the latest release?

No.

What did you do?

Currently, at tip (b459bc8), running all.bash, at the end it prints 2000+ lines of new APIs of vendored golang.org/x packages. This is very verbose. And they are not even part of the standard library API, which I thought the API check is for. Could we not emit those? Thanks.
@bcmills
Copy link
Contributor

bcmills commented Sep 14, 2020

This is probably somehow related to my changes to the all package pattern. I'll take a look.

@bcmills bcmills self-assigned this Sep 14, 2020
@bcmills bcmills added this to the Go1.16 milestone Sep 14, 2020
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Sep 14, 2020
@bcmills
Copy link
Contributor

bcmills commented Sep 14, 2020

Bisected to CL 251159.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/254738 mentions this issue: cmd/api: omit outside dependencies when listing the packages in "std"

@cherrymui
Copy link
Member Author

Thanks @bcmills

@bcmills bcmills changed the title cmd/api: skip vendor directories? cmd/api: erroneously includes vendored dependencies when run inside the 'std' module Sep 14, 2020
@bcmills bcmills changed the title cmd/api: erroneously includes vendored dependencies when run inside the 'std' module cmd/api: omit vendored dependencies when run inside the 'std' module Sep 14, 2020
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 14, 2020
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 14, 2020
@bcmills bcmills mentioned this issue Oct 27, 2020
Open
@golang golang locked and limited conversation to collaborators Sep 14, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @cherrymui