-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/term: Please remove the empty x/term repo #16420
Comments
We can also just ignore x/term for the purposes of #11811. |
How about moving https://godoc.org/golang.org/x/crypto/ssh/terminal#IsTerminal here? |
@davecheney are you sure about CL number, 17611 is about compress/bzip2 - https://go-review.googlesource.com/#/c/17611 |
Submitted https://go-review.googlesource.com/c/38050/ and can work on #19503 |
@techtonik the CL you linked above got some reviews, but it seems like you didn't reply. Are you still interested in continuing work here? I'm interested in this subrepo, so I can help with reviews and some of the work. It would be good for someone who's paid full-time to work on Go to take ownership, but if noone steps up, I can take that job with the free time I can find. Out of curiosity, who is interested and/or would like to spend time on this subrepo in the future? |
@mvdan thanks for the heads up. I've lost control over my emails and missed the notification. Looking at the CL right now. No paid job and no expertise from my side, so don't expect me to take the responsibility. Since I wrote this code, some things happen. I lost hope in the I am a very fan boy of https://www.farmanager.com/ but over two years I am completely on Linux and don't use Far anymore. In Linux TUI applications I can not chain key presses and go grab some coffee until all commands that spawned by keypresses finish execution. TUI interfaces based of parsing and visualizing every character instead of directly manipulating with the video buffer are very very slow. No OpenGL or Vulcan would fix that. I can not save events buffer before starting another process and restore it later, I can not use memory copy operations for showing animations in Unfortunately, I don't have a link to a list of all problems with For me, the EDIT: Making a good TUI module for golang would require changes on Linux level. I am afraid it is out of scope of this project, and there is no mechanism to go deeper. I also tried to find people who still know how deep is that terminal and how it works, and I don't believe that they are still alive. I spent 10 years until by a chance I discovered the concept of |
@techtonik thanks - it's fine if you've lost interest or don't have the time. I think the rest is a bit off-topic :) If you're not going to work on your CL, please abandon it. I'll see if I can get this rolling again with others in the next couple of months. If that fails, I think we should remove the repository for the time being, as Dave suggested. |
I still couldn't find an way to checkout my CL locally from Gerrit. Started editing it online, but then I can not run tests. Well, at least the fixes are just comments. |
@mvdan updated online - https://go-review.googlesource.com/c/term/+/38050 |
Ironically, the (Doubly-ironic, given that the repo has no code and that the Android platform has no terminal.) |
/cc @matloob |
Another package that cound be useful for I am not sure that |
Closing in favor of #31044. The repo is not empty anymore anyway, so can't be removed. Adding things should be tracked in independent proposals. |
The x/term repo was added in Nov 2015 after proposal #13104 was accepted.
Unfortunately the interest in contributing to this repo did not materialise and I have not had the bandwidth to push CL 17611 and will likely continue to not have the bw for the foreseeable future.
As the repo remains effectively empty, I think it is appropriate to remove this repository to stop it blocking #11811.
/cc @adg @bradfitz
The text was updated successfully, but these errors were encountered: