From d339d085c9d0cff099668d3a85ebae4e25c6afa2 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Wed, 11 May 2022 10:42:39 -0400 Subject: [PATCH] cmd/go: add timestamps to script test output Go tests don't include timestamps by default, but we would like to have them in order to correlate builder failures with server and network logs. Since many of the Go tests with external network and service dependencies are script tests for the 'go' command, logging timestamps here adds a lot of logging value with one simple and very low-risk change. For #50541. For #52490. For #52545. For #52851. Change-Id: If3fa86deb4a216ec6a1abc4e6f4ee9b05030a729 Reviewed-on: https://go-review.googlesource.com/c/go/+/405714 Reviewed-by: Dmitri Shuralyov Auto-Submit: Bryan Mills Reviewed-by: Dmitri Shuralyov TryBot-Result: Gopher Robot Run-TryBot: Bryan Mills --- src/cmd/go/script_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/cmd/go/script_test.go b/src/cmd/go/script_test.go index 6254cf97c1c7ec..33bad4d741873f 100644 --- a/src/cmd/go/script_test.go +++ b/src/cmd/go/script_test.go @@ -81,6 +81,7 @@ func TestScript(t *testing.T) { t.Run(name, func(t *testing.T) { t.Parallel() ctx, cancel := context.WithCancel(ctx) + defer cancel() ts := &testScript{ t: t, ctx: ctx, @@ -94,7 +95,6 @@ func TestScript(t *testing.T) { defer removeAll(ts.workdir) } ts.run() - cancel() }) } } @@ -210,6 +210,9 @@ func (ts *testScript) setup() { ts.envMap[kv[:i]] = kv[i+1:] } } + + fmt.Fprintf(&ts.log, "# (%s)\n", time.Now().UTC().Format(time.RFC3339)) + ts.mark = ts.log.Len() } // goVersion returns the current Go version.