-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/poly1305: drop Go 1.12 compatibility #239
Conversation
This PR (HEAD: e79997e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/448239 to see it. Tip: You can toggle comments from me using the |
Message from Roland Shoemaker: Patch Set 1: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Joedian Reid: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Roland Shoemaker: Patch Set 1: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Joedian Reid: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
e79997e
to
87b7b8e
Compare
This PR (HEAD: 87b7b8e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/448239. Important tips:
|
Other packages already dropped compatibility with go1.12, so it should be safe to remove it for this package as well.
87b7b8e
to
1971e03
Compare
This PR (HEAD: 1971e03) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/448239. Important tips:
|
Message from Filippo Valsorda: Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-12-30T12:12:19Z","revision":"0cc6f8e6f6f7d2917c571a254ec3457eb646f6f8"} Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Filippo Valsorda: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Joedian Reid: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Message from Joedian Reid: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/448239. |
Other packages already dropped compatibility with go1.12, so it should be safe to remove it for this package as well. Change-Id: Ieecc7cd06a0a4e69e8c1c09ef6fefe95d78ceb75 GitHub-Last-Rev: 1971e03 GitHub-Pull-Request: #239 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/448239 Reviewed-by: Joedian Reid <joedian@google.com> Auto-Submit: Filippo Valsorda <filippo@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Filippo Valsorda <filippo@golang.org> Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This PR is being closed because golang.org/cl/448239 has been merged. |
Other packages already dropped compatibility with go1.12, so it should be safe to remove it for this package as well. Change-Id: Ieecc7cd06a0a4e69e8c1c09ef6fefe95d78ceb75 GitHub-Last-Rev: 1971e03 GitHub-Pull-Request: golang#239 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/448239 Reviewed-by: Joedian Reid <joedian@google.com> Auto-Submit: Filippo Valsorda <filippo@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Filippo Valsorda <filippo@golang.org> Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Other packages already dropped compatibility with go1.12, so it should be safe to remove it for this package as well.