Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a date extractor from user defaults. #459

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Adding a date extractor from user defaults. #459

merged 1 commit into from
Oct 25, 2017

Conversation

Khalian
Copy link
Collaborator

@Khalian Khalian commented Sep 24, 2017

Checklist

  • New Extension
  • New Test
  • Changed more than one extension, but all changes are related
  • Trivial change (doesn't require changelog)

@Khalian Khalian force-pushed the dateuserdef branch 2 times, most recently from 364329c to 0d67116 Compare September 24, 2017 00:08
@EZSwiftExtensionsBot
Copy link

EZSwiftExtensionsBot commented Sep 24, 2017

3 Messages
📖 Executed 203 tests, with 0 failures (0 unexpected) in 6.704 (7.034) seconds
📖 Executed 188 tests, with 0 failures (0 unexpected) in 5.953 (6.122) seconds
📖 Executed 125 tests, with 0 failures (0 unexpected) in 5.165 (5.236) seconds

Generated by 🚫 Danger

func testDate() {
let testUserDefaults = UserDefaults(suiteName: "TEST")
let key = "dateTestKey"
let date: Date = Date()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the Type Interference rule, please remove type as it follows:
let date = Date()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Khalian Khalian merged commit 45a5728 into master Oct 25, 2017
@Khalian Khalian deleted the dateuserdef branch October 25, 2017 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants