-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r32 changelog #1427
Comments
I will help to update this changelog from time to time. Feel free to reword/rewrite any entries as you like. |
I have merged a few more PRs, all of which are small, primarily to maintain the progress of |
@joelim-work Sorry to disappear for a long time and thank you very much keeping everything in order. I will try to go over the PRs that you already approved and merge them in the upcoming days. I will also try to drop some comments in discussions where my feedback is requested. I should note that I often try to skim through issues and PRs daily even though I'm not actively participating in discussions myself. I might try to join if I realize something that can be considered a red flag. So feel free to merge patches more liberally when I'm not around. I owe to participate in discussions at the very least if I want to be included in the decision making process. This also includes things that I have objected against before in the past (e.g. fsnotify) Having said that, it feels a little strange that you are much more active than I am in a repository with my name. We can bring up the possibility of creating an organization if it can make you more comfortable. Let me know if you are interested in this and I will take a look at what we can do. Happy holidays and see you after your break. |
@gokcehan Thanks, hope you had a good break too, also happy new year to you. Normally I try to avoid directly tagging you, but sometimes there are decisions that are controversial in nature, or are otherwise difficult to decide on, and I will seek feedback from you. I have also lately found myself to be on the conservative side when it comes to decision-making (e.g. rejecting PRs or feature requests where they either extremely niche and/or could be achieved via user configuration). Regarding the idea of changing the repository ownership to a GitHub organization, perhaps it's another way of opening up the project to more users who wish to contribute, but I have honestly not given this much thought. I was actually thinking of slightly decreasing my activity here (compared to the previous year), partly for myself, but also to give others the opportunity to participate in the development of Anyway I think things are fine as they are now, you don't have to change anything if you don't want to. |
@joelim-work Thank you very much for keeping the notes up to date. I guess there is nothing else we need for the release now. About the timing of the release, I will be a little busy in the next two days. Maybe I can take a look at this in the weekend or next week. Or alternatively maybe you can try to do the release yourself this time. I'm curious if there is still anything required on my side to make a new release, and this could be a nice opportunity to give it a try. To make a new release, the only thing required is the following (we could also have these in our documentation somewhere):
|
@joelim-work Forgot to mention, we also need to update the documentation if it is not up to date yet. By the way, I just realized we have this in our CONTRIBUTING.md:
Perhaps we should add "optionally" or something similar to this sentence to avoid the hard requirement of docker for contributions. |
Hi @gokcehan I'm not really sure about taking over the release process, I still prefer to leave it to you as it is your project, although I don't mind things like reviewing the incoming PRs, and updating the generating documentation every now and then. Regarding the actual release itself, it doesn't have to be this week or anything - it's not that urgent. I was just suggesting it because it's been a while since the last release. Maybe it might be better to wait for a couple of weeks anyway as a freeze period. |
@joelim-work A couple of weeks freeze period sounds good then. |
@joelim-work I was planning to make a release today, but there seems to be some patches that can be considered bug fixes, so I think maybe we should merge them and leave the release for another week. |
@gokcehan That's fine, I didn't expect so many PRs would be created in the last couple of weeks. I am not in a rush for these kind of things anyway. BTW I have written a regex to check for incorrectly formatted lines in the changelog, I'm not sure how you verify them otherwise: grep -vE '^- \*\*\((Breaking|New|Fix)\)\*\* .+ \([0-9]+\) \(by [^ ]+\)\.$' <filename> |
Changelog
etc/lfcd.cmd
is updated to use the-print-last-dir
option instead of-last-dir-path
(Use-print-last-dir
option forlfcd.cmd
#1444) (by @atahrijouti and @joelim-work). Similar changes have been made foretc/lfcd.ps1
(Use-print-last-dir
option forlfcd.ps1
#1491) (by @alunegov),etc/lfcd.fish
(Enable completions and add description for lfcd.fish and simplify the code #1503) (by @postsolar), andetc/lfcd.nu
(Update lfcd.nu to support nushell >= 0.87.0 #1575) (by @ZennoZenith).lf -doc
and thedoc
command is now generated from Markdown usingpandoc
(use markdown for the documentation #1474) (by @gokcehan).hidecursorinactive
is added to hide the cursor when the terminal is not focused (Add hidecursorinactive option to indicate status when terminal loses focus #965) (by @laktak).on-redraw
is added to be able to run a command when the screen is redrawn or when the terminal is resized (Addon-redraw
hook command #1479) (by @joelim-work).cutfmt
,copyfmt
andselectfmt
are added to configure the indicator color for cut/copied/selected files respectively (Allow customization for cut/copy/select colors #1540) (by @joelim-work).zsh
completion is added for thelfcd
command (lf.zsh
: make completions complete bothlf
andlfcd
#1564) (by @postsolar).lf_mode
is now exported to indicate which modelf
is currently running in (Export mode for use in scripting keybindings #1594) (by @joelim-work).rulerfmt
option is now left-padded with spaces to visually separate it from the file stat information (Add spaces torulerfmt
to separate from statinfo #1437) (by @joelim-work).lfcd
scripts (Print sixel data to stderr instead of stdout #1451) (by @joelim-work).high
andlow
commands whenscrolloff
is set to a large value (Fixlow
/high
crash for bigscrolloff
values #1504) (by @joelim-work)..gitignore
) are named correctly afterpaste
if another file with the same name already exists (fix basename being.
when it is empty #1525) (by @joshuali925).SIGINT
(Continue responding to signals after initial sigint #1549) (by @mtoohey31).cd
command to change to a directory for the first time (Improve refreshing of file statinfo #1536) (by @joelim-work).mark-save
/mark-remove
operation (Reload file info aftermark-save
/mark-remove
#1544) (by @joelim-work).marks
andtags
files now raise an error message instead of crashing (Fix crash if tags/marks contains invalid entry #1614) (by @joelim-work).paste
operation succeeds (Clear cut buffer only when paste succeeds #1652) (by @joelim-work)..
is ignored to set the cursor position when renaming a directory (Ignore extension when renaming directory #1664) (by @Limero).period
should not cause flickers in sixel previews anymore (Skip drawing UI for period timer #1666) (by @joelim-work).The text was updated successfully, but these errors were encountered: