Skip to content

Commit

Permalink
removing max message byte and compression type from json response as …
Browse files Browse the repository at this point in the history
…it is not configurable now (#175)

Co-authored-by: leonlnj <ningjie.lee@gojek.com>
(cherry picked from commit a085bca)
  • Loading branch information
leonlnj committed Mar 7, 2022
1 parent a3d788d commit 8a4fbd4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions api/turing/models/log_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ type KafkaConfig struct {
// Serialization Format used for the messages
SerializationFormat SerializationFormat `json:"serialization_format"`
// Producer Config - Max message byte to send to broker
MaxMessageBytes int `json:"max_message_bytes"`
MaxMessageBytes int `json:"-"`
// Producer Config - Compression Type of message
CompressionType string `json:"compression_type"`
CompressionType string `json:"-"`
}

// LogConfig contains all log configuration necessary for a deployment
Expand Down
4 changes: 1 addition & 3 deletions api/turing/models/log_config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,7 @@ func TestLogConfigValue(t *testing.T) {
"kafka_config": {
"brokers": "test-brokers",
"topic": "test-topic",
"serialization_format": "test-serialization",
"max_message_bytes" : 10000,
"compression_type" : "none"
"serialization_format": "test-serialization"
}
}`),
},
Expand Down

0 comments on commit 8a4fbd4

Please sign in to comment.