Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources.GetRemote #7083

Closed
iinfin opened this issue Mar 22, 2020 · 7 comments
Closed

Add resources.GetRemote #7083

iinfin opened this issue Mar 22, 2020 · 7 comments

Comments

@iinfin
Copy link

iinfin commented Mar 22, 2020

As far as I'm aware current SRI function requires resources.Get, which requires the file to be in assets folder.

I think it'd be nice if we can use it also with external files
Thanks!

@bep
Copy link
Member

bep commented Mar 22, 2020

We have another issue about resources.GetRemote which would solve this (and more).

@iinfin
Copy link
Author

iinfin commented Mar 22, 2020

Ah yes, GetRemote sounds like a convenient solution! It could make external sources modular and make the site flexible overall (to copy/inline, minify, hash them during build)

I suppose you're referring to #5686 PR though, seems to be closed due to inactivity.

@bep bep changed the title SRI hash for external files Add resources.GetRemote Mar 26, 2020
@bep bep added Enhancement and removed Proposal labels Mar 26, 2020
@bep bep added this to the v0.69 milestone Mar 26, 2020
@bep bep modified the milestones: v0.69, v0.70 Apr 8, 2020
@bep bep modified the milestones: v0.70, v0.71 Apr 28, 2020
@bep bep modified the milestones: v0.71, v0.72 May 18, 2020
@bep bep modified the milestones: v0.72, v0.73 May 31, 2020
@bep bep modified the milestones: v0.73, v0.74 Jun 23, 2020
@bep bep modified the milestones: v0.74, v0.75 Jul 13, 2020
@bep bep modified the milestones: v0.75, v0.76 Sep 14, 2020
@bep bep modified the milestones: v0.76, v0.77 Oct 6, 2020
@bep bep modified the milestones: v0.77, v0.78 Oct 30, 2020
@atishay
Copy link

atishay commented Dec 20, 2020

This can be very useful for also fetching images from external sources and processing them to the right size before bundling.

#5686 has been inactive for a while though.

@bep bep modified the milestones: v0.78, v0.83 Apr 23, 2021
@bep bep removed this from the v0.83 milestone May 3, 2021
@bep bep added this to the v0.101.0 milestone May 31, 2022
@bep bep modified the milestones: v0.101.0, v0.102.0 Jun 16, 2022
@bep bep modified the milestones: v0.102.0, v0.103.0 Aug 28, 2022
@bep bep modified the milestones: v0.103.0, v0.104.0 Sep 15, 2022
@bep bep modified the milestones: v0.104.0, v0.105.0 Sep 23, 2022
@bep bep modified the milestones: v0.105.0, v0.106.0 Oct 26, 2022
@bep bep modified the milestones: v0.106.0, v0.107.0 Nov 18, 2022
@bep bep modified the milestones: v0.107.0, v0.108.0 Dec 3, 2022
@bep bep modified the milestones: v0.108.0, v0.109.0 Dec 14, 2022
@bep bep modified the milestones: v0.109.0, v0.111.0, v0.110.0 Jan 26, 2023
@bep bep modified the milestones: v0.111.0, v0.112.0 Feb 15, 2023
@jmooring
Copy link
Member

jmooring commented Apr 8, 2023

Addressed with #9185

@jmooring jmooring closed this as completed Apr 8, 2023
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants