Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Amazon S3 storage not work #12357

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Conversation

ninjadq
Copy link
Member

@ninjadq ninjadq commented Jun 30, 2020

The Chartmuseum S3 client need set an Env variable
Ref: helm/chartmuseum#280

Signed-off-by: DQ dengq@vmware.com

The Chartmuseum S3 client need set an Env variable
Ref: helm/chartmuseum#280

Signed-off-by: DQ <dengq@vmware.com>
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #12357 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12357      +/-   ##
==========================================
+ Coverage   56.02%   56.11%   +0.09%     
==========================================
  Files         942      945       +3     
  Lines       54403    54538     +135     
  Branches     1798     1798              
==========================================
+ Hits        30480    30606     +126     
- Misses      20465    20471       +6     
- Partials     3458     3461       +3     
Flag Coverage Δ
#unittests 56.11% <ø> (+0.09%) ⬆️
Impacted Files Coverage Δ
....com/goharbor/harbor/src/common/utils/passports.go 86.36% <0.00%> (-4.55%) ⬇️
...ortal/src/lib/components/config/gc/gc.component.ts 58.73% <0.00%> (-3.18%) ⬇️
....com/goharbor/harbor/src/lib/selector/candidate.go 57.14% <0.00%> (ø)
...or/src/lib/selector/selectors/severity/selector.go 93.54% <0.00%> (ø)
...r/src/lib/selector/selectors/signature/selector.go 100.00% <0.00%> (ø)
...harbor/harbor/src/pkg/p2p/preheat/policy/filter.go 81.81% <0.00%> (ø)
.../src/lib/selector/selectors/doublestar/selector.go 77.02% <0.00%> (+0.97%) ⬆️
...com/goharbor/harbor/src/jobservice/runner/redis.go 67.67% <0.00%> (+4.04%) ⬆️
...arbor/src/lib/selector/selectors/label/selector.go 100.00% <0.00%> (+30.43%) ⬆️

@ywk253100 ywk253100 merged commit 1d03b87 into goharbor:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Env variable "AWS_SDK_LOAD_CONFIG" is needed for chartmuseum to work with s3 service account
3 participants