Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance test issue -- POST request with digest and blob should yield a 201 #11946

Closed
wy65701436 opened this issue May 15, 2020 · 4 comments
Closed
Assignees

Comments

@wy65701436
Copy link
Contributor

wy65701436 commented May 15, 2020

This issue is a sub-task of the OCI Conformance testing epic (#11943)

~~~ REQUEST ~~~
POST  /v2/conformance/testrepo/blobs/uploads/?digest=sha256%3A66ad98165d38f53ee73868f82bd4eed60556ddfee824810a4062c4f777b20a5b  HTTP/1.1
HOST   : ******
HEADERS:
	Authorization: Bearer *****
	Content-Length: 113
	Content-Type: application/octet-stream
	User-Agent: distribution-spec-conformance-tests
BODY   :
ewoJImFyY2hpdGVjdHVyZSI6ICJhbWQ2NCIsCgkib3MiOiAibGludXgiLAoJImNvbmZpZyI6IHt9LAoJInJvb3RmcyI6IHsKCQkidHlwZSI6ICJsYXllcnMiLAoJCSJkaWZmX2lkcyI6IFtdCgl9Cn0=
------------------------------------------------------------------------------
~~~ RESPONSE ~~~
STATUS       : 202 Accepted
RECEIVED AT  : 2020-05-15T06:41:38.733127379Z
TIME DURATION: 28.505218ms
HEADERS      :
	Connection: keep-alive
	Content-Length: 0
	Date: Fri, 15 May 2020 06:41:38 GMT
	Docker-Distribution-Api-Version: registry/2.0
	Docker-Upload-Uuid: 66595367-55dd-41a5-aa8d-c674073cf4fe
	Location: https://10.193.21.1/v2/conformance/testrepo/blobs/uploads/66595367-55dd-41a5-aa8d-c674073cf4fe?_state=*****
	Range: 0-0
	Server: nginx
	Set-Cookie: sid=a0d637056c90e2c9d9ded49d6a893174; Path=/; HttpOnly
	X-Request-Id: 91ff7cd7-b9d8-470c-b203-cd6eeb21db01
BODY         :

Expected
: 202
to equal
: 201

@reasonerjt
Copy link
Contributor

This is the one Josh mentioned they will revisit the oci-spec, right?

@wy65701436 wy65701436 changed the title Conformance test issue -- Blob Upload Monolithic Conformance test issue -- POST request with digest and blob should yield a 201 May 18, 2020
@renmaosheng
Copy link
Contributor

@wy65701436 could you please share your discussion with Josh here? do we have a ticket in distribution repo too? thanks.

@jdolitsky jdolitsky mentioned this issue Jul 10, 2020
3 tasks
@wy65701436
Copy link
Contributor Author

PR to fix on OCI part: opencontainers/distribution-spec#171

@stale
Copy link

stale bot commented Nov 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Nov 25, 2020
@stale stale bot closed this as completed Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants