fix(contrib/drivers/pgsql): fix insert error when data struct field has nil in PgSQL #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gqcn
approved these changes
Jul 11, 2024
gqcn
requested changes
Jul 11, 2024
| var ( | ||
| fieldValueKind = reflect.TypeOf(fieldValue).Kind() | ||
| ) | ||
| if fieldValue == nil { |
There was a problem hiding this comment.
在golang里面的interface{}判断为== nil会有坑，因为它在内部需要判断类型和值，类型不相同时判断会失效，所以这里需要使用框架封装的IsNil方法来判断避免踩坑。这里可以使用g.IsNil来判断。
gqcn
requested changes
Jul 17, 2024
| var ( | ||
| fieldValueKind = reflect.TypeOf(fieldValue).Kind() | ||
| ) | ||
| if fieldValue == nil { |
There was a problem hiding this comment.
在golang里面的interface{}判断为== nil会有坑，因为它在内部需要判断类型和值，类型不相同时判断会失效，所以这里需要使用框架封装的IsNil方法来判断避免踩坑。这里可以使用g.IsNil来判断。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3668