Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de-virtualize the /v3 path, remove go.mod from root #65

Closed
acln0 opened this issue Dec 3, 2018 · 2 comments
Closed

de-virtualize the /v3 path, remove go.mod from root #65

acln0 opened this issue Dec 3, 2018 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@acln0
Copy link
Member

acln0 commented Dec 3, 2018

As discussed in the #gofrs Slack channel, perhaps we finally have a resolution for #61.

The plan is to de-virtualize the /v3, remove go.mod from the project root, and add forwarding declarations and type aliases in the /v3 subdirectory, followed by cutting v3.2.0.

If anyone is willing to do this work and submit it for review, that would be great. Please ping me when you do. I had previously sent c6f696b which is the other way around. There, the forwarding package is the root package, while /v3 contains the actual code. Perhaps it would be good to base the work on that commit, but we want to do it the other way around. The root package should be the canonical one, and we bite the bullet for a while to support existing modules users using the /v3 subdirectory.

What happens with a potential v4.0.0 in the future remains to be seen.

@acln0 acln0 added the help wanted Extra attention is needed label Dec 3, 2018
@itsjamie itsjamie self-assigned this Dec 3, 2018
@itsjamie
Copy link
Contributor

itsjamie commented Dec 3, 2018

I'll do this in the next four hours.

@theckman
Copy link
Member

Based on learnings from @thepudds we've realized this wasn't needed. We instead removed the go.mod and are relying on the reproducible build nature of Go Modules to have it continue to work for those who have depended on the modules version. We are encouraging people move back to the incompatible module by removing v3 from the import string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants