diff --git a/leveldb/README.md b/leveldb/README.md index 7e345858..d5fd64bf 100644 --- a/leveldb/README.md +++ b/leveldb/README.md @@ -11,7 +11,7 @@ title: LevelDB A fast key-value DB using [syndtr/goleveldb](https://github.com/syndtr/goleveldb) -**Note: Requires Go 1.23.1 and above** +**Note: Requires Go 1.21 or later** ### Table of Contents diff --git a/leveldb/config_test.go b/leveldb/config_test.go index 44e0781d..962831e8 100644 --- a/leveldb/config_test.go +++ b/leveldb/config_test.go @@ -4,21 +4,21 @@ import ( "runtime" "testing" - "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" ) func TestConfigConfigMaxOpenFiles(t *testing.T) { cfg := Config{ MaxOpenFiles: 1000, } - assert.Equal(t, 1000, cfg.MaxOpenFiles) + require.Equal(t, 1000, cfg.MaxOpenFiles) } func TestConfigDefaultDarwin(t *testing.T) { // MacOS cfg := configDefault() if runtime.GOOS == "darwin" { - assert.Equal(t, 200, cfg.MaxOpenFiles) + require.Equal(t, 200, cfg.MaxOpenFiles) } else { - assert.Equal(t, 500, cfg.MaxOpenFiles) + require.Equal(t, 500, cfg.MaxOpenFiles) } } diff --git a/leveldb/go.mod b/leveldb/go.mod index 878c4bdc..a2dd2cf5 100644 --- a/leveldb/go.mod +++ b/leveldb/go.mod @@ -1,6 +1,6 @@ module github.com/gofiber/storage/leveldb -go 1.23.1 +go 1.23 require ( github.com/davecgh/go-spew v1.1.1 // indirect diff --git a/leveldb/leveldb.go b/leveldb/leveldb.go index 478c06f0..6ac4ddac 100644 --- a/leveldb/leveldb.go +++ b/leveldb/leveldb.go @@ -42,7 +42,6 @@ func New(config ...Config) *Storage { // Get value by key func (s *Storage) Get(key []byte) ([]byte, error) { - if len(key) <= 0 { return nil, nil } diff --git a/leveldb/leveldb_test.go b/leveldb/leveldb_test.go index 53beafe1..8f80164d 100644 --- a/leveldb/leveldb_test.go +++ b/leveldb/leveldb_test.go @@ -1,7 +1,6 @@ package leveldb import ( - "fmt" "os" "testing" "time" @@ -226,16 +225,15 @@ func Benchmark_Set(b *testing.B) { _ = removeAllFiles("./fiber.leveldb") }() + key := []byte("test_key") + value := []byte("test_value") + b.ResetTimer() b.RunParallel(func(pb *testing.PB) { - var i int for pb.Next() { - key := []byte(fmt.Sprintf("key_%d", i)) - value := []byte(fmt.Sprintf("value_%d", i)) if err := db.Set(key, value, 0); err != nil { b.Fatal(err) } - i++ } }) } @@ -270,18 +268,17 @@ func Benchmark_Delete(b *testing.B) { _ = removeAllFiles("./fiber.leveldb") }() + key := "test_key" + if err := db.Set([]byte(key), []byte("test_value"), 0); err != nil { + b.Fatal(err) + } + b.ResetTimer() b.RunParallel(func(pb *testing.PB) { - var i int for pb.Next() { - key := fmt.Sprintf("key_%d", i) - if err := db.Set([]byte(key), []byte("value"), 0); err != nil { - b.Fatal(err) - } if err := db.Delete(key); err != nil { b.Fatal(err) } - i++ } }) }