Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 v3 Request: tls.ClientHelloInfo in handlers #1927

Closed
abusessender opened this issue Jun 2, 2022 · 7 comments · Fixed by #2011
Closed

🚀 v3 Request: tls.ClientHelloInfo in handlers #1927

abusessender opened this issue Jun 2, 2022 · 7 comments · Fixed by #2011
Assignees
Milestone

Comments

@abusessender
Copy link

Is your feature request related to a problem?
No

Describe the solution you'd like
I need tls.ClientHelloInfo in route handlers, can it be made in fiber v3?

@welcome
Copy link

welcome bot commented Jun 2, 2022

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@efectn efectn added this to the v3 milestone Jun 2, 2022
@efectn efectn added this to v3 Jun 5, 2022
@efectn efectn moved this to Todo in v3 Jun 5, 2022
@efectn efectn removed this from v3 Jun 5, 2022
@efectn efectn added this to v3 Jun 5, 2022
@efectn efectn moved this to Todo in v3 Jun 5, 2022
@efectn efectn changed the title 🚀 V3 Request: tls.ClientHelloInfo in handlers 🚀 v3 Request: tls.ClientHelloInfo in handlers Jun 5, 2022
@efectn
Copy link
Member

efectn commented Jun 6, 2022

Can you give an example about this feature? @abusessender

@abusessender
Copy link
Author

Can you give an example about this feature? @abusessender

It does not released in other libraries, it will be good, if you release it first :D

@thomasdseao
Copy link
Contributor

Hi @efectn , Can I work on this ?

@efectn
Copy link
Member

efectn commented Jul 20, 2022

Hi @efectn , Can I work on this ?

Of course

@thomasdseao
Copy link
Contributor

thomasdseao commented Jul 22, 2022

Cool!
I will be back from my holiday on the 15 august. So if it can wait until the 15, that's perfect for me.
If not don't hesitate to assign it to someone else 🙂 @efectn

@thomasdseao
Copy link
Contributor

Hi @efectn

I made the small changes to get ClientHelloInfo in handlers in this PR : #2011
Let me know if you want me to change some things or maybe where the code is located. (This is my first PR on fiber)

@efectn efectn linked a pull request Aug 12, 2022 that will close this issue
@efectn efectn moved this from Todo to In Progress in v3 Aug 13, 2022
Repository owner moved this from In Progress to Done in v3 Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants