Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤔 Travis test for Windows is commented out, but used in the badge #119

Closed
MarvinJWendt opened this issue Feb 11, 2020 · 3 comments
Closed

🤔 Travis test for Windows is commented out, but used in the badge #119

MarvinJWendt opened this issue Feb 11, 2020 · 3 comments

Comments

@MarvinJWendt
Copy link
Contributor

MarvinJWendt commented Feb 11, 2020 •
edited
Loading

Hi, the README.md states that the Windows build is passing:
image
But windows isn't tested, as it's commented out on the Travis config file:

fiber/.travis.yml

Line 5 in 7946333

# - windows

So technically Windows builds are never tested, and the badge won't change.
Should that be updated?
@welcome
Copy link

welcome bot commented Feb 11, 2020

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template!

@Fenny
Copy link
Member

Fenny commented Feb 11, 2020 •
edited
Loading

Fiber works fine on windows, but I commented it out because of this bug #71 that caused an incomplete build. I'm working on a fix right now, I will keep this open until fixed.

@Fenny
Copy link
Member

Fenny commented Feb 12, 2020 •
edited
Loading

#71 is fixed, and windows #121 is enabled in travis again. Just have to wait for travis build.

@Fenny Fenny closed this as completed Feb 12, 2020
@Fenny Fenny mentioned this issue Feb 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fenny @MarvinJWendt