Clicking on a button in Select Screen popup prints an error

[Giganzo]

Tested versions

4.4.dev1
4.1.2.stable

System information

Fedora Linux 40 (KDE Plasma) - Wayland - Vulkan (Forward+)

Issue description

When clicking on a button in this menu popup

Prints this error:
platform/linuxbsd/x11/display_server_x11.cpp:2084 - Condition "prev_parent == p_parent" is true.

Similar error is printed on Windows too

Steps to reproduce

Right click on Make editor floating button
Click on one of the screen buttons
Error is printed in Output

Minimal reproduction project (MRP)

N/A

[Giganzo]

Error on Windows:

platform/windows/display_server_windows.cpp:1771 - Condition "wd_window.transient_parent == p_parent" is true.

[hunterkepley]

I believe you are using x11 here, you need to go into editor settings and turn on prefer wayland or whatever the option is called (search Wayland)

I am unable to use this feature on wayland in general

[hunterkepley]

[Giganzo]

I believe you are using x11 here, you need to go into editor settings and turn on prefer wayland or whatever the option is called (search Wayland)

I am unable to use this feature on wayland in general

No, this happen on Fedora 39 X11 too and Windows

[hunterkepley]

@Giganzo the error is from the x11 display server: platform/linuxbsd/x11/display_server_x11.cpp:2084 - Condition "prev_parent == p_parent" is true.

[hunterkepley]

on Wayland, the select screen button is greyed out:

At least for me (I am on fedora 39, KDE plasma wayland)

[Giganzo]

on Wayland, the select screen button is greyed out:

At least for me

Yes, if prefer wayland is on. As it uses Single window mode if I understand it correctly.

[hunterkepley]

Was mentioning this to make sure, that the issue is indeed with x11/windows, rather than wayland/windows

Will look into the error 😃

[hunterkepley]

Something interesting; I printed the comparison causing the error (prev_parent and p_parent)

If you start godot after a pop-out window was in use, it will start with that pop-out window, and no error:

WARNING: prev: -1; parent: 0
     at: window_set_transient (platform/linuxbsd/x11/display_server_x11.cpp:2084

If you then close the popout and reopen it, you get the error, and neither the previous window, nor current window, can be found, resulting in equal IDs of -1

WARNING: prev: 0; parent: -1
     at: window_set_transient (platform/linuxbsd/x11/display_server_x11.cpp:2084)
WARNING: prev: -1; parent: 0
     at: window_set_transient (platform/linuxbsd/x11/display_server_x11.cpp:2084)
WARNING: prev: 0; parent: -1
     at: window_set_transient (platform/linuxbsd/x11/display_server_x11.cpp:2084)
WARNING: prev: -1; parent: -1
     at: window_set_transient (platform/linuxbsd/x11/display_server_x11.cpp:2084)
ERROR: Condition "prev_parent == p_parent" is true.
   at: window_set_transient (platform/linuxbsd/x11/display_server_x11.cpp:2085)

[hunterkepley]

Going to leave this here, and hope someone else has an idea, i am unsure why it is getting 2 invalid window IDs for both the new window + the previous window, when it works on startup

[bikemurt]

A couple of notes:

• This issue is present in both the script_editor_plugin.cpp and shader_editor_plugin.cpp. So we know it's upstream from there

  godot/editor/plugins/script_editor_plugin.cpp

  Line 4309 in b6223c0

  make_floating->connect("request_open_in_screen", callable_mp(window_wrapper, &WindowWrapper::enable_window_on_screen).bind(true));

• I traced backwards from the error to here, but can't find how clicking on a "Select Screen" option calls _make_window():

  godot/scene/main/window.cpp

  Line 647 in b6223c0

  DisplayServer::get_singleton()->window_set_transient(E->window_id, transient_parent->window_id);

[bikemurt]

Still investigating, but this looks suspect to me:

godot/editor/window_wrapper.cpp

Line 106 in b6223c0

wrapped_control->reparent(parent, false);

I think it's the transient_parent logic. By reparenting, I think we invalidate the window ID and that's what is generating the error. I don't know why this is necessary.

Here's the call stack in case it helps anyone else:

[bikemurt]

Going to leave this here, and hope someone else has an idea, i am unsure why it is getting 2 invalid window IDs for both the new window + the previous window, when it works on startup

The ID of 0 isn't invalid, it just means main window:

	enum {
		MAIN_WINDOW_ID = 0,
		INVALID_WINDOW_ID = -1,
		INVALID_INDICATOR_ID = -1
	};

I ran a similar test on Windows and I get these values on startup (inside window_set_transient):

wd_window.transient_parent: 0
p_parent: -1

wd_window.transient_parent: 0
p_parent: -1

Then when using the "Select Screen" option I get:

wd_window.transient_parent: 0
p_parent: -1

wd_window.transient_parent: -1
p_parent: -1

So technically it's only the 2nd pass that's causing the issue (transient parent and p_parent are both invalid). Haven't been able to trace what's driving that. Might be something to do with the popup.

One more update: I have been able to generate the error by selecting the Left click option to pop out the script editor, but it happens far less often. It's some weird timing thing with the transient parent and parent being out of sync for validation.

[bikemurt]

If you comment out this line, the error doesn't appear until the popup window is made hidden by losing focus:

godot/editor/window_wrapper.cpp

Line 373 in b6223c0

button->connect(SceneStringName(pressed), callable_mp(static_cast<Window *>(popup), &Popup::hide));

Issue may actually be with the popup window's ID not being valid.