Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcedit Fails to Modify Resources with Console Wrapper Enabled #96546

Open
atlasapplications opened this issue Sep 4, 2024 · 0 comments
Open

Comments

@atlasapplications
Copy link

Tested versions

  • Reproducible in v4.3.stable.mono and v4.2.x.stable.mono
  • rcedit v2.0.0

System information

Windows 11

Issue description

When exporting a Godot project for Windows with the console wrapper enabled, the first executable (which is the console wrapper) properly has its icon and other metadata set by rcedit. But the second executable, (the executable without the wrapper) fails to have any of the its resources modified such as the icon and metadata and falls back to Godot defaults.

This is the error that it gives:

editor/export/editor_export_platform.h:179 - Resources Modification: rcedit failed to modify executable: Fatal 
error: Unable to commit changes

rcedit appears to work as intended when the console wrapper is disabled such as when the release build is used since the default is to not include the console wrapper. It seems this may be an issue with having more than one executable to modify at one time since the console wrapper is the executable that's produced first.

Steps to reproduce

  • Create Godot project.
  • Set up Windows export by specifying all metadata under the Application header.
  • This includes things like specifying an .ico file, company name, etc.
  • Export with console wrapper enabled.

Minimal reproduction project (MRP)

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants