Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor docs not scrolling to correct position on search or ctrl+click of a term #96515

Open
donn-xx opened this issue Sep 3, 2024 · 7 comments

Comments

@donn-xx
Copy link

donn-xx commented Sep 3, 2024

Tested versions

Noticed this since early 4.x. Still happening in latest 4.4 dev.

System information

Godot v4.4.dev (61598c5) - Ubuntu 22.04.4 LTS 22.04 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (nvidia; 535.183.01) - Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz (6 Threads)

Issue description

When you ctrl+click a function in gdscript, the docs open but the help text is at the wrong position. Meaning, the function is often not even on the screen of text you get and you have to scroll or Ctrl+F to locate it.

The same happens when one searches using F1 (or Alt+F1).

This does not happen all the time. It's hard to pin down.

Steps to reproduce

Just play with help and watch.

Minimal reproduction project (MRP)

None

@AdriaandeJongh
Copy link
Contributor

I’m also annoyed by this bug regularly. What does seem to help is going back to the original script and ctrl clicking the variable or method again, after which it will always scroll to the right position. So perhaps this has something to do with the script not being open yet.

@kitbdev
Copy link
Contributor

kitbdev commented Sep 4, 2024

@AdriaandeJongh
Copy link
Contributor

That report seems to be related to a fix introduced between 4.2 and 4.3. I've experienced the bug described in this report throughout 4.2.

@Maran23
Copy link
Contributor

Maran23 commented Sep 5, 2024

There were multiple issues regarding scrolling and navigation in the past.
After #96449, everything should be fine though. If you like you can test the PR and report back. I did quite some testing and scrolling was working perfectly everytime.

@donn-xx
Copy link
Author

donn-xx commented Sep 7, 2024

ETA: Might not have got the right code. I just pulled from main and compiled.

Just compiled from main. Opened a project, ctrl+clicked intersect_ray and it's a few lines into the func:
It's off by several lines

Going back to the code, and doing it again gets it right.

I wonder if this isn't a font/line-spacing/linuxy kind of problem?

@Maran23
Copy link
Contributor

Maran23 commented Sep 7, 2024

No it was just wrong code in Godot that is fixed in #96449.

@donn-xx
Copy link
Author

donn-xx commented Sep 8, 2024

I see it's pending a review. Thanks for the fix and I'll keep en eye out to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants