You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most of the changes in how threads works seems to come from 21701, specifically, the function should be coming from wasm IIUC, while it was also part of the JS file before at least as a stub.
Anyway, I have a feeling removing that stub required a change somewhere else, I'll further investigate (likely tomorrow).
This will most likely require an emscripten patch, we can probably disable CC for editor in this RC, alternatively I've made the best hack I could think of: https://github.com/Faless/godot/tree/web/the_ugliest_cc_hack_you_can_imagine
I tried making a sample reproduction test (using the same Godot flags), but it doesn't seem to mark that function as unused (even if no thread code is present at all):
Well, some more news, it seems I found the relevant upstream issues: emscripten-core/emscripten#21844 .
Though in our case, it also happens if we don't enable dlink (i.e. not using MAIN_MODULE).
Tested versions
master
(f0e20ef)System information
Fedora Linux 40 (KDE Plasma) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 7600M XT (RADV NAVI33) - AMD Ryzen 7 7840HS w/ Radeon 780M Graphics (16 Threads)
Issue description
Using Emscripten 3.1.64, but I tested 3.1.63 and 3.1.62 which have the same issue.
I bisected the regression to #94109.
This error happens on a closure compiler Web editor compilation:
@Faless started looking into it:
Steps to reproduce
scons platform=web target=editor use_closure_compiler=yes verbose=yes scu_build=yes
Minimal reproduction project (MRP)
n/a
The text was updated successfully, but these errors were encountered: