-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenGL: ReflectionProbe is not reimplemented yet #86318
Comments
Started working on this. Edit: This doesn't look like an easy task at all lol |
Just a quick update. I feel like I am so close to having anything rendered into the reflection probe, however I am not sure how to deal with render targets and framebuffers yet. I am literally learning OpenGL as I go. Now I need to figure out how to render to the texture. This is fun! :) |
how is this going? Feel free to share some of the implementation details, either here or maybe DMs on the contributors chat. i am really interested the implementation of this but seems overwhelming with my background, i hardly know where to start. |
I feel lost at shaders and atlases. |
that's okay! it took me a long time to get comfortable with even the basics of opengl, and im still new to graphics and dev work in general. youve been learning it on the fly for a couple of weeks or less, and brave enough to take on such a task. so i think youre doing great. i hope you can stay motivated, seek help where you can, and do what you need to do, whether you decide to put this task on the backburner or keep at it. |
Now that I know how to bind data to a scene shader, sending the data into it is my main priority. However atlases are still the biggest problem for me lmao. Learning Vulkan first was the best thing I could've done! :) |
Giving up on it for now. I will try to understand Godot's shader pre-processing, if I do then I will work on it further and give an update. |
Tested versions
Godot v4.2.1.stable
System information
Fedora Linux 38.20231205.0 (Silverblue) - Wayland - GLES3 (Compatibility) - AMD Radeon RX 550 / 550 Series (polaris12, LLVM 16.0.6, DRM 3.54, 6.6.3-100.fc38.x86_64) () - AMD Ryzen 5 3400G with Radeon Vega Graphics (8 Threads)
Issue description
Reflection Probe makes a huge difference in fidelity at a really low cost, which makes it a good choice for mobile games.
However Reflection Probe is still missing in Compatibility backend.
Compatibility backend:
![image](https://private-user-images.githubusercontent.com/71460040/291434179-ddc94aac-346e-49e1-bcd1-ff5f2560d340.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3NzYwNzYsIm5iZiI6MTczODc3NTc3NiwicGF0aCI6Ii83MTQ2MDA0MC8yOTE0MzQxNzktZGRjOTRhYWMtMzQ2ZS00OWUxLWJjZDEtZmY1ZjI1NjBkMzQwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA1VDE3MTYxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM0YmZkZTljMjdjZjBmY2I2MzliOTI2ZDE0Y2U3ZjQ0Zjk5Njg5MDdiNmM5OGUyOGZlMmU2NmM5YWUyZGQ3OWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.p3-wwk6-NFPxtkhG06odXSXsTjHSJwEGoAwm0gDv0_0)
Mobile backend:
![image](https://private-user-images.githubusercontent.com/71460040/291434241-5d756186-1f0c-43e2-bcf8-1989403d9c4c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3NzYwNzYsIm5iZiI6MTczODc3NTc3NiwicGF0aCI6Ii83MTQ2MDA0MC8yOTE0MzQyNDEtNWQ3NTYxODYtMWYwYy00M2UyLWJjZjgtMTk4OTQwM2Q5YzRjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA1VDE3MTYxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZhZDJlMmE0NGJhOTllYjNlMDViMDFlZDdiNDg3ZmIwNzBkNzNiM2JkYjY3ZTc3ODE0NDNlMTNiYTI2ZDdkMmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.tJZWME_TSpoMwVnWWLX_pxQhS79-sH8k6UOMPfR4qrc)
Steps to reproduce
Create Reflection Probe while using Compatibility backend to see that nothing happens. Which isn't the case with backends using RenderingDevice (Mobile and Forward+).
Minimal reproduction project (MRP)
N/A
The text was updated successfully, but these errors were encountered: