Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationPlayer now resets on every frame it is called #82828

Closed
zapposh opened this issue Oct 5, 2023 · 2 comments · Fixed by #82898
Closed

AnimationPlayer now resets on every frame it is called #82828

zapposh opened this issue Oct 5, 2023 · 2 comments · Fixed by #82898

Comments

@zapposh
Copy link

zapposh commented Oct 5, 2023

Godot version

4.2 dev 6

System information

Windows 11

Issue description

Prior to Godot 4.2 dev 6, calling play("animation") on an animation repeatedly simply continues playback of the animation.

In Godot 4.2 dev 6, repeatedly calling a looping animation causes it to restart/reset every time it is called.

func _process(delta): $AnimationPlayer.play("animation_name")

For ex. the above example now restarts at 0 on every frame.

Steps to reproduce

  • Create a new project in Godot 4.2 dev 6
  • Add an AnimationPlayer node to your scene, and create a looping animation for a parameter of your choice.
  • Playing the animation in the editor works as expected
  • Create a script to call the animation at regular intervals (for ex. every frame)
  • Press F5 to launch run the project -> now the animation player resets to 0 on every call

Minimal reproduction project

N/A

@sepTN
Copy link
Contributor

sepTN commented Oct 5, 2023

I'm hit by this bug as well. When I tried to open my project with 4.2 dev 6 I noticed that my pawns aren't properly animating. But when I switch on my older compile, it does properly animating and no longer freeze in their frame 0. Could be a regression somewhere.

@TokageItLab
Copy link
Member

TokageItLab commented Oct 5, 2023

I guess it is due to the change in behavior for the current_from; Probably it fails to recognize that it is trying to play the same animation. I'll take a look into it over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants