Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 to 4 converter: raise -> move_to_front #68357

Closed
wdv4758h opened this issue Nov 7, 2022 · 2 comments · Fixed by #68801
Closed

3 to 4 converter: raise -> move_to_front #68357

wdv4758h opened this issue Nov 7, 2022 · 2 comments · Fixed by #68801

Comments

@wdv4758h
Copy link

wdv4758h commented Nov 7, 2022

Godot version

4.0.beta4

System information

Linux

Issue description

Didn't see raise() -> move_to_front() convert entry in project_converter_3_to_4.cpp, probably need one?

Ref: Rename raise() to move_to_front() #60108

Steps to reproduce

As description, just wanna check if it's a missing.

Minimal reproduction project

No response

@vincentmoreschi
Copy link
Contributor

vincentmoreschi commented Nov 16, 2022

We would have to do more then just function rename since the function got moved from node to canvas item, or is adding it to just the list of rename enough?

@akien-mga
Copy link
Member

Just adding to the renames should be sufficient for most cases. While it's technically possible for users to have been using it on a Node that doesn't inherit CanvasItem, it's unlikely. If they do, they'll get an error, but they would anyway without performing the rename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants