Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL: Light3D shadow rendering is not reimplemented yet #66596

Closed
Tracked by #66458
Henrique-Henrique opened this issue Sep 29, 2022 · 9 comments · Fixed by #77496
Closed
Tracked by #66458

OpenGL: Light3D shadow rendering is not reimplemented yet #66596

Henrique-Henrique opened this issue Sep 29, 2022 · 9 comments · Fixed by #77496

Comments

@Henrique-Henrique
Copy link

Godot version

4.0.beta1

System information

Windows 10/11

Issue description

Shadow dont work when using OpenGL3 driver

In editor:
image

In Game:
image

Steps to reproduce

  1. Create a Project
  2. Change on Project Settings the Rendering Driver to OpenGL3
  3. Add some MeshInstance3D with Mesh
  4. Add DirectionalLight3D or any light node and active Shadow on Inspector
  5. Add Camera3D

Minimal reproduction project

shadow.zip

@akien-mga akien-mga added this to the 4.0 milestone Sep 29, 2022
@akien-mga akien-mga moved this to To Assess in 4.x Priority Issues Sep 29, 2022
@akien-mga akien-mga moved this from To Assess to Todo in 4.x Priority Issues Sep 29, 2022
@Calinou
Copy link
Member

Calinou commented Sep 29, 2022

This is because shadows haven't been implemented yet in the OpenGL renderer 🙂

@Calinou Calinou changed the title Shadows don't work on Godot 4 using OpenGL3 OpenGL: Shadow rendering is not reimplemented yet Sep 29, 2022
@Calinou Calinou changed the title OpenGL: Shadow rendering is not reimplemented yet OpenGL: Light3D Shadow rendering is not reimplemented yet Sep 29, 2022
@Calinou Calinou changed the title OpenGL: Light3D Shadow rendering is not reimplemented yet OpenGL: Light3D shadow rendering is not reimplemented yet Sep 29, 2022
@Henrique-Henrique
Copy link
Author

I imagined, thanks! 😁

@clayjohn clayjohn removed this from the 4.0 milestone Dec 6, 2022
@aragubas

This comment was marked as off-topic.

@Calinou
Copy link
Member

Calinou commented Feb 18, 2023

@aragubas Please don't bump issues without contributing significant new information. Use the 👍 reaction button on the first post instead.

Since Godot 4.0 is in release candidate stage, this will only be implemented in a future 4.x release.

@Calinou Calinou added this to the 4.x milestone Feb 18, 2023
@clayjohn clayjohn modified the milestones: 4.x, 4.1 Feb 19, 2023
@Zireael07

This comment was marked as off-topic.

@clayjohn clayjohn added this to the 4.2 milestone Jun 13, 2023
@clayjohn
Copy link
Member

Bumping to 4.2 as I need to do more performance analysis to ensure that the current implementation is indeed optimal from a performance perspective. :( I just ran out of time for 4.1

@joined72
Copy link
Contributor

Bumping to 4.2 as I need to do more performance analysis to ensure that the current implementation is indeed optimal from a performance perspective. :( I just ran out of time for 4.1

Any news about performance improvements?

@Calinou
Copy link
Member

Calinou commented Nov 27, 2023

Any news about performance improvements?

OpenGL shadows have been merged in 4.2, following this comment which addresses performance issues that were in the initial (unmerged) implementation.

@joined72
Copy link
Contributor

Any news about performance improvements?

OpenGL shadows have been merged in 4.2, following this comment which addresses performance issues that were in the initial (unmerged) implementation.

Great! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants