Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very bright objects does not approach/become white with filmic tonemapper #66591

Closed
atirut-w opened this issue Sep 29, 2022 · 2 comments
Closed

Comments

@atirut-w
Copy link
Contributor

Godot version

v4.0.beta1.official [20d6672]

System information

N/A

Issue description

This is basically godotengine/godot-proposals#3214 but for the Filmic tonemapper. It seems that both ACES and Filmic are supposed to have this behavior according to Blender, but only ACES got the "fitted" treatment despite Filmic being the "preferred" tonemapper in 4.0 according to the tonemapper used if you enabled tonemap in the preview world env.

This issue also applies to 3.x.
For details about Filmic, see Color Grading and Filmic Tonemapper(Unreal Doc)

Blender reference:
Screenshot_20220929_172545

Comparison of ACES and Filmic in 4.0
ACES:
Screenshot_20220929_172244
Filmic:
Screenshot_20220929_172340

Same comparison in 3.x
ACES Fitted:
Screenshot_20220929_171928
Filmic:
Screenshot_20220929_172002

Steps to reproduce

  1. Set up a scene with a world env, set tonemapper to Filmic
  2. Place down some objects and a high energy directional light.

Minimal reproduction project

No response

@atirut-w atirut-w changed the title High energy emissive material does not approach/become white with filmic tonemapper Very bright objects does not approach/become white with filmic tonemapper Sep 29, 2022
@Calinou
Copy link
Member

Calinou commented Sep 29, 2022

despite Filmic being the "preferred" tonemapper in 4.0 according to the tonemapper used if you enabled tonemap in the preview world env.

See #49736.

@Calinou Calinou added this to the 4.0 milestone Sep 29, 2022
@Calinou Calinou moved this to To Assess in 4.x Priority Issues Sep 29, 2022
@clayjohn clayjohn removed this from the 4.0 milestone Jan 14, 2023
@clayjohn
Copy link
Member

This isn't a bug, it is a feature proposal. Feature proposals should be made in the https://github.com/godotengine/godot-proposals repository

@clayjohn clayjohn closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants