Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra suffix is not appended at the end of a binary name in some cases #37301

Open
Tracked by #39196
Xrayez opened this issue Mar 25, 2020 · 2 comments
Open
Tracked by #39196

Extra suffix is not appended at the end of a binary name in some cases #37301

Xrayez opened this issue Mar 25, 2020 · 2 comments

Comments

@Xrayez
Copy link
Contributor

Xrayez commented Mar 25, 2020

Godot version:
3.0, 4.0

OS/device including version:
Windows 10, likely any other OS.

Steps to reproduce:

With mono module enabled:

scons platform=windows target=release_debug bits=64 module_mono_enabled=yes mono_glue=no extra_suffix=mygame

Results in binary name such as:
godot.windows.opt.tools.64.mygame.mono.exe

Should be like:
godot.windows.opt.tools.64.mono.mygame.exe

With sanitizers:

scons platform=linuxbsd target=debug tools=yes use_asan=yes use_lsan=yes extra_suffix=mygame

Results in binary name such as:
godot.linuxbsd.tools.64.mygames (notice appended s)

Should be like:
godot.linuxbsd.tools.64.s.mygame


Should likely be handled by refactor as suggested in #24030.

@neikeq
Copy link
Contributor

neikeq commented Apr 2, 2020

I've removed the topic:mono label as this is an issue with module name suffixes (even though the mono module is the only one using that right now).

@Xrayez Xrayez changed the title Extra suffix is not appended at the end of a binary name with mono module enabled Extra suffix is not appended at the end of a binary name in some cases Jul 31, 2020
@Xrayez
Copy link
Contributor Author

Xrayez commented Jul 31, 2020

First time compiling with sanitizer support on linuxbsd to test #40921, sanitizer suffixes are also appended after extra_suffix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants