Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving platform and 3D issues #36483

Closed
fabriceci opened this issue Feb 23, 2020 · 6 comments
Closed

Moving platform and 3D issues #36483

fabriceci opened this issue Feb 23, 2020 · 6 comments

Comments

@fabriceci
Copy link
Contributor

fabriceci commented Feb 23, 2020

Godot version:
OS/device including version:
All

Issue description:

It seems to be an already know issue because it was mostly fixed in 3.1 for the 2D part and this blog post announces that "they will be ported to the 3D engine". However as I can't find any issue related to this on Github, so I created this one.

In summary in vertical movement, the body "enter" in the platform, and in horizontal movement, there is inertia when changing direction. (strangely move_and_slide_with_snap worsens the issue)

Minimal reproduction project:
here

@madmiraal
Copy link
Contributor

It's unclear to me what the issue is.

  • The functions mentioned in the blog you refer to, all do exist in 3D.
  • In your example project I don't see the body entering the platform.
  • I also don't understand what you mean by there being inertia when changing direction.

I would suggest closing this issue and creating a separate issue for each problem. Then, clearly explain what the current behaviour is and what the expected behaviour is. Also, provide an minimal reproduction project that clearly shows the problem. Finally, you should upload the minimal project directly to Github instead of using a link to an external storage provider.

@fabriceci
Copy link
Contributor Author

fabriceci commented May 24, 2020

It's unclear to me what the issue is.
I also don't understand what you mean by there being inertia when changing direction.
The functions mentioned in the blog you refer to, all do exist in 3D.

Thanks to the interest @madmiraal. Indeed, I should have explained the issue instead of link a blog post. The issue is: "When a body is on a moving platform, he doesn't follow the platform's movements.” Maybe the issue should be renamed "Add sync to physics checkbox to 3D KinematicBody"

If you read the blog post, in the part, "SYNC TO PHYSICS", you will understand what I called inertia in the gif. In 2D, 3.1 fix that with the "sync to physics" checkbox, but this checkbox doesn't exist in 3D KinematicBody.

When a body is on a moving platform, you expect that the body follows the platform without moving/sliding/inertia (see the blog post).

In your example project I don't see the body entering the platform.
creating a separate issue for each problem.

If you observe the cube movement, you will see it's not linear but step by step because it collides. That's the same issue, because the body doesn't follow properly, it collides.

@madmiraal
Copy link
Contributor

Add sync to physics checkbox to 3D KinematicBody

That would make this a feature request and not a bug. Feature requests should be made here.

@fabriceci
Copy link
Contributor Author

That would make this a feature request and not a bug.

I'm not agree, it's a possible solution.

Either a KinematicBody follow the platform's movement, or not. But currently, it follows the platform but it doesn't do it well, which seems to me to be a bug. You can see why in the blog post I linked about the same issue in 2D:

When a KinematicBody is moved around, it automatically computes its linear and angular velocity [...] This makes KinematicBody also very useful for moving platforms [...] its motion was always a frame ahead than the physics, so the character appears to slowly slide over it. To compensate with this, a new option "Sync to Physics" was added.

If I'm wrong, feel free to close the issue.

@madmiraal
Copy link
Contributor

@fabriceci I agree it's a desirable feature, but it's still a feature request; even if a blog post suggested it would be implemented in the future.

All feature and improvement proposals for the Godot Engine are now being discussed and reviewed in the dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.

The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, all feature proposals on the main issue tracker are being closed.

Assuming you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal).

@fabriceci
Copy link
Contributor Author

@madadam No problem, it's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants