You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Steps to reproduce:
Client A trying to send a RPC to a disconnected client B through rpc_unreliable_id or rpc__id. It depends on a race if client has up-to-date peers list or not. Seems to bug more from HTML5 client than native client.
Godot version:
3.1 and 834d07c (master)
OS/device including version:
Linux_x86_64
Issue description:
Websocket server crash on null deref when receiving wrong destination id.
It seems p_to parameter in https://github.com/godotengine/godot/blob/master/modules/websocket/websocket_multiplayer_peer.cpp#L272 is not sanitized and can lead to a null deref if it does not (longer?) exist.
Steps to reproduce:
Client A trying to send a RPC to a disconnected client B through rpc_unreliable_id or rpc__id. It depends on a race if client has up-to-date peers list or not. Seems to bug more from HTML5 client than native client.
Backtrace:
Proposed patch
Paquebot@4de9500
The text was updated successfully, but these errors were encountered: