Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes attached to a KinematicBody randomly get stuck in space #16994

Closed
mysticfall opened this issue Feb 25, 2018 · 7 comments
Closed

Nodes attached to a KinematicBody randomly get stuck in space #16994

mysticfall opened this issue Feb 25, 2018 · 7 comments

Comments

@mysticfall
Copy link
Contributor

mysticfall commented Feb 25, 2018

Godot version:
master / 6e200b1

OS/device including version:
Manjaro Linux 17.1

Issue description:
I have a 3D character with rigged animations. I made the root of the hierarchy as KinematicBody and attached other items like hair, clothes, and camera to it.

Then within _PhysicalProcess, I move the whole hierarchy with MoveAndSlide and also change position of a single control bone in the same process.

About 8 out of 10 times, it works as expected. But sometimes, random parts like camera or hair, or even multiple bones 'fall apart' from the character when I move it, resulting in something quite interesting as shown in the screenshot below (I wish I could make a video of it - it actually looks way cooler when it moves) :
screenshot_20180225_083640

When it happens for such items like clothes or bones, they get stuck in the space but still move according to the character animation, albeit in a distorted manner.

I know it's a bit vague but have little idea how to track down the problem further. If you could suggest any way to test it on my part, please let me know.

@mysticfall
Copy link
Contributor Author

mysticfall commented Feb 25, 2018

It took me more than 30 attempts to reproduce it and capture it to a video but it was totally worth it 😛 :

I feel tempted to somehow find a way to reliably reproduce it and make a game out of it.

@mysticfall
Copy link
Contributor Author

It may or may not be relevant to my issue, but someone from the Discord channel suggested that #16450 looks similar to this problem.

@AndreaCatania
Copy link
Contributor

The thing is, why fix it? is so cool :D seems an effect made adoc.

Joking apart I think that you are wronging something.... but in order to be sure it's required that you send a sample project

@mysticfall
Copy link
Contributor Author

mysticfall commented Feb 27, 2018

Most relevant code that pertains to the issue can be seen from this location:

As you can see, it's a relatively simple code and the most unusual thing I'm doing is probably changing bone position by code every physical frame, which I believe to be a permitted operation.

And sometimes even the camera is detaching (or getting stuck in space) from the character hierarchy in the same manner as clothes do, so I doubt if it's something related to the way the character is rigged or how I'm moving one of its bones that could be the main cause.

@AndreaCatania
Copy link
Contributor

Is it possible for you test if this bug still happen with: #28909

@mysticfall
Copy link
Contributor Author

In fact, I haven't seen this symptom for quite a while. I'm not too sure what exactly, but apparently something must have fixed the issue for me already.

I'll reopen the issue if I ever see it happen again. Thanks!

@akien-mga akien-mga added this to the 3.1 milestone May 15, 2019
@AndreaCatania
Copy link
Contributor

Ok let me know thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants