Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement importing HDR images as tonemapped LDR (8-bit) images #886

Closed
fire opened this issue Mar 4, 2018 · 2 comments · Fixed by godotengine/godot#58164
Closed

Implement importing HDR images as tonemapped LDR (8-bit) images #886

fire opened this issue Mar 4, 2018 · 2 comments · Fixed by godotengine/godot#58164
Milestone

Comments

@fire
Copy link
Member

fire commented Mar 4, 2018

Describe the project you are working on:
3d multiplayer game

Describe the problem or limitation you are having in your project:
I want to use openexr for standard texture usage too.

Describe the feature / enhancement and how it helps to overcome the problem or limitation:

Take a hdr (openexr) image, unable to make it a 8bit image.

Describe how your proposal will work, with code, pseudocode, mockups, and/or diagrams:

Take the hdr image and tone map it.

If this enhancement will not be used often, can it be worked around with a few lines of script?:
Image modification is cpu intensive.

Is there a reason why this should be core and not an add-on in the asset library?:

Import code is already being owned by the built in openexr module, so have to modify the openxrr module.

@fire fire transferred this issue from godotengine/godot May 25, 2020
@Calinou
Copy link
Member

Calinou commented May 28, 2020

Out of curiosity, what do you need a 8-bit image for? Shouldn't importing an HDR image once be more efficient overall?

@fire
Copy link
Member Author

fire commented May 28, 2020

I wanted to use openexr as a file format like psd or krita. Openexr can store both channels (rgba, and anything else) and layers.

Why is this useful?

  1. I can store all the properties of a PBR material as one image. This requires some tooling to reassign non rgba openexr channels to the proper ones in Godot.
  2. Downconvert a hdr image to rgba8 so one can see it via tone mapping operators. Like screenshots of the linear stages of Godot can be visualized. I think this can be done via https://docs.godotengine.org/en/stable/classes/class_image.html#class-image-method-convert but you can't specify the tone mapper.

Note:

Also, this was my first few first issues from 2018. It brings back memories of a different time.

@Calinou Calinou changed the title Unable to reimport hdr image as 8 bit image Ability to reimport an HDR image as a tonemapped LDR (8-bit) image Jun 5, 2020
@Calinou Calinou changed the title Ability to reimport an HDR image as a tonemapped LDR (8-bit) image Implement importing HDR images as tonemapped LDR (8-bit) images Nov 3, 2021
@akien-mga akien-mga added this to the 4.0 milestone Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants