Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create theme type for nodes created with GDExtension #8003

Closed
acgc99 opened this issue Oct 6, 2023 · 2 comments
Closed

Create theme type for nodes created with GDExtension #8003

acgc99 opened this issue Oct 6, 2023 · 2 comments

Comments

@acgc99
Copy link

acgc99 commented Oct 6, 2023

Describe the project you are working on

A plugin with widgets for mobile apps. I'm moving from GDScript to GDExtension.

I'm new to GDExtension so there might be a way to do so, but since there aren't online tutorials and I cannot figure out how to do that looking at Godot source code for inspiration, I'm requesting this feature.

Describe the problem or limitation you are having in your project

I would like to define theme types for the widgets for customization (it doesn't have too much sense to distribute the plugin without customization).

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Adding theme types for GDExtension nodes would improve customization for plugins.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Add corresponding functions to do so.

If this enhancement will not be used often, can it be worked around with a few lines of script?

I don't think so.

Is there a reason why this should be core and not an add-on in the asset library?

This is about improving GDExtension.

@Daylily-Zeleen
Copy link

Daylily-Zeleen commented Oct 6, 2023

You can get the default theme by ThemeDB::get_singleton()->get_default_theme() and do some customization for your own classes.

@YuriSizov
Copy link
Contributor

Hey there! This is already covered by #4486. I've recently made changes in the engine itself which formalize theme definitions for classes. We'll try to expose this to scripting and extensions by 4.3.

@YuriSizov YuriSizov closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants