Add a resolution argument to CanvasItem.draw_circle()

[CarpenterBlue]

Describe the project you are working on

I am slowly patching up my submission to GMTK23 jam.

Describe the problem or limitation you are having in your project

I want to draw a big single circle but the resolution (it's hardcoded to 64) is too small.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

I would like to replace the hardcoded value with an argument that defaults to 64 for backwards combability.
And possibly add logic to to clamp it to minimum value of 3.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

I would like to give contributing to Godot a shot and this seems like an easy first commit.
I found the code defining the circle here. As you can see on line 1151, the resolution seems to be hardcoded to 64, I would like to move this to an additional argument that defaults to 64 for backwards combability.

If this enhancement will not be used often, can it be worked around with a few lines of script?

For something so simple, and quite frankly essential for custom drawing, the user has to write their own implementation with GDScript which is extremely annoying so yes it can be easily worked around with a script but this is about quality of life.

Is there a reason why this should be core and not an add-on in the asset library?

This is too small of an addition to be an addon in the asset library and simultaneously too big of an issue to not do something about it. You either put up with ugly circle or waste 10 minutes on your own implementation when it could be an argument.

[CarpenterBlue]

As a side effect, it allows to draw circles at smaller resolutions like hexagons which is very much desirable feature.

[Calinou]

• Related to Add a Shape2D node to draw 2D shapes #1126.

See godotengine/godot#14416, which exposed this parameter (and more, such as drawing filled circles and changing the line thickness). Godot now supports MSAA in 2D when the using Forward+ or Mobile rendering methods, so this comment is likely outdated now.

That PR would have to be recreated from scratch at this point though, since a lot of the 2D drawing code has changed.

In the meantime, you can use this add-on in 3.x.

[CarpenterBlue]

I have taken a look at the pull request and that seems very unnecessarily over-complicated to me.
I just want filled circle with points , all of that logic seems like feature creep because for everything else there is draw_arc().

[jsjtxietian]

So is it worth to add a additional resolution argument for now? Or we just recreate the godotengine/godot#14416 directly ?

[Calinou]

So is it worth to add a additional resolution argument for now? Or we just recreate the godotengine/godot#14416 directly ?

There's a separate proposal about adding filled and width options to draw_circle(), so a PR should only concern itself with adding a resolution parameter now.

[SleepProgger]

So, is there any chance to get this added ?
The arbitrary decision to always use 64 points is kinda strange, especially considering that draw_arc has the point count parameter and draw_circle does not.