Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag specific commits for each Godot stable version #53

Closed
akien-mga opened this issue Jul 25, 2019 · 7 comments
Closed

Tag specific commits for each Godot stable version #53

akien-mga opened this issue Jul 25, 2019 · 7 comments

Comments

@akien-mga
Copy link
Member

Follow-up on #24, which added dedicated branches for stable Godot versions, matching the Godot repository.

In 3.1.1 we broke GDNative compatibility with 3.1 to fix a security issue, so the need to tag stable version arises. I propose to use the same convention as the Godot repository and to tag specific commits from the stable branches with matching 3.1-stable, 3.1.1-stable, etc. tags.

IINM, 489db27 would be 3.1-stable and 98ee825 would be 3.1.1-stable.
It might be worth tagging 3.0.x versions in the 3.0 branch too (it's OK if several tags share the same commit if no update happened in the meantime).

I can do this if we agree on this versioning. CC @karroffel @BastiaanOlij

I'm also working on an update of http://docs.godotengine.org/en/latest/tutorials/plugins/gdnative/gdnative-c-example.html which includes some misleading information. Once we have tags, I would suggest that this tutorial makes people checkout the actual tag matching their Godot version, instead of assuming compatibility.

@akien-mga
Copy link
Member Author

BTW, I'd suggest to do the same for the godot-cpp repo. I see that it already has some 0.1.0 and 1.0.0 pre-releases: https://github.com/GodotNativeTools/godot-cpp/releases

Do those make semantic sense, and if not should we remove them and replace them by the matching Godot versions? Or if they do make sense, are there more versions that should be tagged? We could then tag Godot versions with a godot- prefix, e.g. godot-3.1.1-stable, to make it clear that it's about the engine and not bindings version.

@akien-mga
Copy link
Member Author

I can do this if we agree on this versioning.

Actually I can't as I don't have Write access to this repo :P

@karroffel
Copy link
Contributor

I added the tags godot-3.1-stable and godot-3.1-stable

@akien-mga
Copy link
Member Author

@karroffel The godot-3.1-stable tag is good, but the other one is wrongly named with an extra dot: godot-3.1.1.-stable.

@karroffel
Copy link
Contributor

karroffel commented Jul 27, 2019

Oops, will fix!
Edit: done

@pewsplosions
Copy link

Will there be a tag for 3.2 now that its the latest stable branch? Doing the GDNative tutorial and it says it is best to use a version of the headers with matching tag to version of Godot I am using. But there doesn't seem to be a 3.2 at the moment.

@akien-mga
Copy link
Member Author

This can be closed, releases have properly been tagged from 3.1-stable onward: https://github.com/godotengine/godot-headers/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants