getting_started/first_2d_game/07.finishing-up

[giscus[bot]]

getting_started/first_2d_game/07.finishing-up

We have now completed all the functionality for our game. Below are some remaining steps to add a bit more "juice" to improve the game experience. Feel free to expand the gameplay with your own ide...

https://docs.godotengine.org/en/latest/getting_started/first_2d_game/07.finishing-up.html

[ninlar]

It appears that the node types are now AudioStreamPlayer2D instead of just AudioStreamPlayer. I had to correct that in the code to get the music to play. Very awesome to complete this tutorial.

[Calinou]

Both AudioStreamPlayer and AudioStreamPlayer2D still exist in Godot 4. AudioStreamPlayer should be used for music playback, as it's non-positional, while AudioStreamPlayer2D should be used for positional audio (i.e. most sound effects).

[ninlar]

Whoops I see it now. Not sure how I missed that node :(

[K-Princ]

how can add touchscreen input to this if i export this game to android?

[timhutton]

One way is to move the player towards where the user is touching. In player.gd, add:

var touch_is_down = false
var touch_target

func _input(event):
	if event is InputEventScreenTouch:
		if event.pressed:
			touch_is_down = true
			touch_target = event.position
		elif event.released:
			touch_is_down = false
	elif event is InputEventScreenDrag:
		touch_target = event.position

and then in _process() you can add:

	if touch_is_down and position.distance_to(touch_target) > 5:
		velocity = touch_target - position

[sync-oz]

I made a small addition that may be suitable for here, which is hiding the player when the app runs and showing them when the game starts. I thought seeing the player on the title screen was odd.

Added

func new_game():
    ...
	$Player.show()

func _ready():
	$Player.hide()

[ZakariGames]

This was already part of the tutorial actually! :D

Right before adding the collisions in the "Coding the Player" section is when we add the hide() function to the player's _ready() function.

"When you're sure the movement is working correctly, add this line to _ready(), so the player will be hidden when the game starts:"

"hide()"

And then at the very end of the "Coding the Player" section, the show() function is added to the player's start() function:

"The last piece is to add a function we can call to reset the player when starting a new game."

func start(pos):
position = pos
show()
$CollisionShape2D.disabled = false

[PortableFox]

For the sound effects section mine was missing the Loop checkbox. However based on this forum post I was able to do this by connecting the AudioStreamPlayer's finished() node to main and telling it to start playing the music when the audio finished signal fired like so

func _on_music_finished() -> void:
	$Music.play()

[associateone]

All audio is automatically imported with the Loop setting disabled. If you want the music to loop seamlessly, click on the Stream file arrow, select Make Unique, then click on the Stream file and check the Loop box.

[MartinDelille]

Awesome tutorial!

Regarding the looping, I was not very happy to discover that the audio file looked to be embedded in the main.tscn file:

[sub_resource type="OggPacketSequence" id="OggPacketSequence_atmdh"]
packet_data = Array[Array]([[PackedByteArray("AXZvcmJpcwAAAAACRKwAAP/////Q3QYA/////7gB")], [PackedByteArray("A3ZvcmJpcx0AAABYaXBoLk9yZyBsaW...
granule_positions = PackedInt64Array(0, 0, 1856, 5568, 9664, 13760, ...
sampling_rate = 44100.0

I noticed it happened when I clicked "Make unique". I managed to enable the loop playback by editing the "art/House In a Forest Loop.ogg.import" file when I changed loop to true.

[mark-wiemer]

Ugh, I've followed all these instructions and still nothing :(

1. Godot 4.3 with GDScript

2. Enable Loop in the Audio Stream Importer:

   

3. Reimport

4. Make Unique in AudioStreamPlayer > Stream > down arrow > Make Unique:

   

At this point I expect a loop button to appear somewhere in the editor, but no luck. I've tested the game and the music ends, it doesn't loop :(

[mark-wiemer]

That said, looping via code works fine :) and you don't need to make it unique either, so that avoids the large embedding in the .tscn file mentioned earlier

[markusmeier345]

It seems that the Looping option has moved to the Parameters section

[Calinou]

Pull request opened:

• Link to Exporting projects in Finishing up page of Your first 2D game godot-docs#9976

[SteeveBlanc]

to export the game and show it proudly :
Project/Export
Add...
Windows runnable / Mac
it says some config files are missing
add them with the option on the right, Godot downloads automatically from best source
ok, re-open Project/Export
this time you are allowed to press Export project
create a subfolder and choose it
Go.
4 files are generated (on Windows), 3 are necessary but the console.exe seems optional
you can zip the folder with 3 files and send it

[thomzd]

While pressing the button I get this error:

E 0:00:01:0767 event_get_action_status: The InputMap action "start_game" doesn't exist. Did you mean "ui_text_caret_document_start"?
<C++ Error> Condition "!E" is true. Returning: false
<C++ Source> core/input/input_map.cpp:262 @ event_get_action_status()

screenshot: https://puu.sh/KfJ4y/1c74694461.png

[thomzd]

EDIT: even though I have the start_game function in my script:

signal start_game
#...
func _on_start_button_pressed() -> void:
$StartButton.hide()
start_game.emit()

[jsonjunkie]

seems like you might need to add the start_game Input Map. go to Project > Project Settings > Input Map and then add new action named start_game

[jessodum]

I don't know if this is something new in 4.3 (I'm completely new to Godot as of this week), but I think I found easier instructions to enable the music looping.

Instead of this:

If you want the music to loop seamlessly, click on the Stream file arrow, select Make Unique, then click on the Stream file and check the Loop box.

... do this instead:

In the Inspector for the Music node, expand the Parameters under AudioStreamPlayer and make sure both the "Looping" and "On" checkboxes are checked.

[ElectricZax]

This is what I used. I didn't even find the first one and I thought it was me. But your comment made me look for it again and I found it.

Thank you.

[ElectricZax]

I don't know what is the proper protocol here... but can we have a separate page or section or maybe a Discord group where we can discuss various ways we improve and build on the game and how to do new things?

For example I added a button with function "boost", so when I press it the speed of my creep will double.
if Input.is_action_pressed("move_right"):
velocity.x += 1*boost

But I can't make an "if" condition to increase the speed when score > 30 for example (because I don't know how to setup the if rule to check the score).

[Kushal-Dev94]

The score variable is stored in the script attached to the main node (main.gd) and is updated by calling the update_score() method of hud.gd.

So you can emit a signal from main when the score goes above 30, connect that signal to your player node, where you can apply the boost or increase the speed.

[ElectricZax]

I could not make the "game_start" button to work. (I skipped part of the instructions, because I thought it was related to the controller support).
In the end I added to the main script the below code and it worked.

func _process(delta):
	if Input.is_action_pressed("start_game"):
		new_game()

[pikaphew9000]

My game is not working.
The MObs are off scale and rotation I cant fix it
Also instead of running the main scene as its supposed to it runs the player scene when i press the run button

[Eilliw11]

I'm seeing a lot of little snips and pieces of the finished script we're supposed to write, but where these pieces go is pretty vague, and I'm almost certain not complete. It looks like there is an assumption that once you've got something figured out in one place, you'll automatically know what goes in somewhere else without any instruction. That's not really the case. Does the completed project exist somewhere to compare what I've done to a known good example? Then I can see if something is in the wrong place or if anything is missing. I can go through line by line, and see it's doing everything I told it to do. It just isn't doing everything the example is doing. Without a known good script to compare it to, I can't see the mistake neither I nor the debugger caught.

[Eilliw11]

Oh! Found it. Godot-demo-projects/2d/dodge_the_creeps. Found all three scripts right there. Not even a minute after asking, I found it. But if anyone is just a LITTLE off, there is a known good example. Literally one letter off for mine.

[schaefchenaufderweide]

After finishing, my player suddenly disappeaed. After this i am convinced, godot is not for me. It would really be helpful, if you shard the complete code.

[Calinou]

You can find the completed demo project here: https://godotengine.org/asset-library/asset/2712

[Huzal]

I had the same problem and it turns out I was dumb and skipped this line during the Background portion of this page:

Make it the first node under Main so that it will be drawn behind the other nodes.

Kind of important if you want to see what is happening to not make the background a foreground :P

Though I'm not sure why only the player gets drawn under the rectangle while the HUD and Mobs are still over top of it.

[Fares-Charni]

Before exporting (process is explained in other comments, documentation or this youtube video: https://www.youtube.com/watch?v=31W2ti676RE ) you should assign a main node. To do so, Go to "Project Parameters -> General -> Application -> Run" and select Main as you main node. This will solve the problem with running your executable.
On the other side, don't forget to put ColorRect as the first child of Main so it doesn't cover Player.
Otherwise, very cool tutorial , happy to discover godot :)

[Aapuji]

The art, music, sounds, etc. are all really cool for a noob like me. How would I go about creating art and sounds for games I make? What would you suggest? How did the creators of this tutorial make them? How would you suggest I learn how to make good art/music?

[hansintheair]

So, just to make sure I understood the shortcut part correctly, by setting the shortcut property on the StartButton of the HUD to start_game, and mapping start_game to Keyboard Spacebar or Controller button A, hitting the shortcut acts like a pressed event for the button?

[RobbiewOnline]

I hit a very odd issue, after setting the shortcut for the Start button to start_game, I found that the game wouldn't start when pressing the enter key, but worse was that clicking the button with the mouse only partially started the game.

The Start button would disappear, but the enemy never displayed and the music didn't play.

I quit & restarted the game, it consistently froze after hiding the Start button.

I decided to debug this by adding a breakpoint to the new_game function, but, when debugging the game worked! I then quit + restarted the game and then it would play by using the mouse by clicking on the Start button every time.

In desperation I reverted my code using GitHub, repeated the process and got exactly the same weird quirk, I had to debug to unblock the start_game function!

As of now, the game consistently runs.

I still however don't have the shortcut setup for the ketboard, even though I followed the instructions.

I'm using GoDot 4.3 on a MacBook Air (Apple M2). I'll try discord to ask for tips and will reply here if I get an answer.

[lukegrob]

Slightly delayed but i just had a similar situation. I read your more recent comment also, but..

I use F6 to run the game to play it (which runs current scene) when i should probably be pressing F5 (run the main scene of the project). Because I was in the hud window to access the startButton (to add the shortcut), i was pressing f6 and actually running the hud, which looks almost the same except no bg colour and no mobs spawn -- i press the button, the button disappear, as if the game is running, but then nothing else happens for me, because of course I am running the wrong scene.

Once I made sure i was running the main scene (or using f5), it worked every time for me.

This may not be your issue (I see you went further with trying to debug), but as my experience was similar and in the same place, I just wanted to say, just in case!

[RobbiewOnline]

Amazing - thank you for highlighting this.

Funny enough I created a comment to one of their tutorials where I've given similar advice!

It's likely other n00bs will hit it, so hopefully being prominent in the tutorial will be an aha moment.

It feels now that the getting started user guide needs to warn n00bs that this may happen and to keep an eye out for it 😅

[tangramor]

I cannot make the shortcut part work until I change it to InputEventKey and configure it to use Enter

[RobbiewOnline]

Did you experience the weird issue I had (comment prior to yours)

I found that the game wouldn't start when pressing the enter key, but worse was that clicking the button with the mouse only partially started the game.

[tangramor]

no...My env is Windows 10 with GoDot 4.3

[Jacinto73]

I finished it. Everything works. I have tried so many times on previous versions to get this going and there was always something that frustrated me and I'd quit. Thank you, whoever made this one. I can't say I understood the math functions at all (I'm an artist, not a programmer). And the relationship between nodes and their inherited properties/methods either. Like it took me forever to figure out how I was able to rotate the sprite (that it inherits that property from Node2D or whatever. I just might be able to make my RPG someday. Freakin love Godot

[leowribeiro]

Guys I made my first game on Godot based on Dodge the Creeps, I called it "Squids" check it out!
https://youtu.be/QkIBNgWTg2c
I tried to put some spark in Dodge the Creeps, please tell me what you think about it!

[RobbiewOnline]

Gosh your high score increments extremely fast, I'd reduce the pace to be at most once per second, otherwise it's difficult to track and be motivated to beat such a high and difficult to grok number.

The launch graphic looks very nice, the main game play almost looks identical, except the addition of the health bar, so no instant death.

The ending has been improved.

Well done for making some tweaks to make your first game. How about changing more of the gameplay, for example different coloured enemy, some may change direction or speeds, some might blow up, some might spawn babies, etc

[lowbit]

Setting players/mobs or both collision shapes a bit smaller then the sprite makes for more enjoyable experience where the player gets better satisfaction in near misses and might get less annoyed at deaths by blaming himself being bad then the game.

[Calinou]

On the other hand, making their collision shapes smaller will make squashing more difficult. Ideally, you'd make it so the player's hitbox for squashing is larger than its actual collision with mobs if you were to go that route.

[callumscreativearts]

Hello, I finished this tutorial and only encountered one problem (which isn't all too bad since it's my first time working with Godot). Everything worked until I put the ColorRect node into the scene tree. When the ColorRect node was visible, my player would be hidden, even though the ColorRect node was underneath all my main components. Other than that, my game functions as it should, but it would be nice to fix the issue with the background and not seeing the player. The mobs still appear, and the the HUD is visble, only the player is invisible (but very much still there and colliding with the mobs) when the ColorRect node enters my project. Great guide though!

[callumscreativearts]

actually, disregard my issue I have figured out the problem :P

[niteshkumar098official]

My Github account got 'SUSPENDED' after pushing - "House in a forest loop.ogg" and "gameover.wav" on Github.

Today I completed this chapter - "Finishing up" of Godot Docs.
I was pushing my code on Github from beginning of this tutorial, Till this date everything was going smooth but as I pushed "BackgorundMusic" and "DeathSound" I got suspended without any reason or mail.
Just after pushing background music and death sound, I export this game with the help of "Official Github Releases Mirror" template and try to push "export.zip" file in the same repository but I got below error in the terminal.

PS D:\Dodage the creeps> git push
remote: Your account is suspended. Please visit https://support.github.com for more information.
fatal: unable to access 'https://github.com/nitesh098suthar/dodge-the-creeps.git/': The requested URL returned error: 403

I try to access my github account in browser but it was showing your account got suspended - https://github.com/nitesh098suthar

Currently, I'm not able to access my Github account and I want it back as it contains multiple important repositories for me. I tried to contact Github Support but did not get any reply.

If anybody know how can I get my Github account back, Please help me.

[RobbiewOnline]

Nitesh 1. Raise a support ticket https://docs.github.com/en/support/contacting-github-support/creating-a-support-ticket 2. GitHub typically sends notifications regarding account issues. Look for any emails from GitHub about suspicious activities or policy violations. (Also check your spam folder) Kind Regards, Rob.

[niteshkumar098official]

Thank you for the response Rob. I double checked my Gmail account as well as spam folder. I did not get any mail regarding suspension.
I raised a ticket and hoping for reply from Github staff.

Best Regards
Nitesh.