-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Issue tracker" link on godot-cpp README.md actually points to Godot issues #1206
Comments
Not necessarily a mistake I reckon. If it's a bug with GDExtension in general it's supposed to be in Godot. If it's specifically the cpp binding it belongs here imho. CC @dsnopek |
@paddy-exe Oh it makes sense. But if this is the original intent, maybe the Readme could be rephrased to convey it more explicitly? |
It could be. There needs to consensus about the handling first though. |
Hm, this is a little tricky. Sometimes the issues that folks using godot-cpp encounter are actually Godot bugs and belong in that repo, and sometimes they are in godot-cpp itself. Casual users may not be able to tell which repo an issue belongs in, although, it shouldn't matter too much: when we start to investigate the issue, we can always make a new issue in the correct repo. Personally, I'd probably err on the side of making issues in this repo, since it's easier for things to get lost in the sea of issues on the Godot repo. So, perhaps we should update the link in the README? What do other folks think? |
This was my reasoning when creating this issue, FWIW. |
Looking at the specific wording in the README, which talks about finding a "list of known issues", I think it makes sense to still link to the Godot issue tracker. In PR #1221, I've changed the link to the Godot issue tracker to filter for GDExtension issues and added a link to the godot-cpp issues as well. (This PR also includes a number of other README fixes that have come up recently.) |
Godot version
4.1.stable
godot-cpp version
4.1.stable
System information
N/A
Issue description
The link to the issue tracker on godot-cpp
README.md
points to the Godot tracker.I reckon the intent is to point to https://github.com/godotengine/godot-cpp/issues instead?
Steps to reproduce
See
README.md
on github and:godot-cpp/README.md
Line 55 in 5eebc6b
Minimal reproduction project
N/A
The text was updated successfully, but these errors were encountered: