Skip to content

Commit 3d27d36

Browse files
committed
Squashed commit of the following:
commit 84b6708 Merge: fef5593 1a0243e Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 19:43:16 2019 -0700 Merge pull request #6 from goddessfreya/goddessfreya-patch-1 Add clang testing commit 1a0243e Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 19:37:34 2019 -0700 Update nodejs.yml commit 18e838f Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 19:35:27 2019 -0700 Delete package-lock.json commit d17cf27 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 19:22:57 2019 -0700 Update nodejs.yml commit 81c5ae6 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 19:12:42 2019 -0700 Update nodejs.yml commit 2db0f18 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:56:33 2019 -0700 Update nodejs.yml commit 855c3c1 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:49:38 2019 -0700 Update nodejs.yml commit f80be0a Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:38:49 2019 -0700 Update nodejs.yml commit 3c52d66 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:35:04 2019 -0700 Update nodejs.yml commit 5fe3493 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:34:31 2019 -0700 Update nodejs.yml commit 8c41771 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:34:05 2019 -0700 Update nodejs.yml commit 5bd03fe Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:33:49 2019 -0700 Update nodejs.yml commit aab4c50 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:33:35 2019 -0700 Update nodejs.yml commit 0e6f86f Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:30:31 2019 -0700 Update nodejs.yml commit fef5593 Merge: 0c83612 e99e477 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:16:48 2019 -0700 Merge pull request #5 from abetomo/fix_deprecated_callback Fix deprecated callback commit 0c83612 Merge: 2c0d135 5cbdece Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:04:18 2019 -0700 Merge pull request #4 from goddessfreya/Add-Github-actions Add Github actions commit 5cbdece Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:01:01 2019 -0700 Delete appveyor.yml commit 4ddcbd3 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 18:00:49 2019 -0700 Delete .travis.yml commit c6f6c63 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 17:57:45 2019 -0700 Update nodejs.yml commit 84bccbd Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 17:55:23 2019 -0700 Update nodejs.yml commit f6720ea Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 17:50:59 2019 -0700 Update nodejs.yml commit 514a3f9 Author: Freya Gentz <zegentzy@protonmail.com> Date: Thu Dec 19 17:31:31 2019 -0700 Add Github actions commit e99e477 Author: abetomo <abe@enzou.tokyo> Date: Thu Jul 5 10:25:35 2018 +0900 Fix deprecated callback The following warning. ``` ../src/worker.cc: In member function ‘virtual void CheckSpellingWorker::HandleOKCallback()’: ../src/worker.cc:44:25: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations] callback->Call(2, argv); ``` Signed-off-by: Freya Gentz <zegentzy@protonmail.com>
1 parent 39fdca5 commit 3d27d36

File tree

2 files changed

+13
-371
lines changed

2 files changed

+13
-371
lines changed

.github/workflows/nodejs.yml

+13-6
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,30 @@ jobs:
99
matrix:
1010
node-version: [8.x, 10.x, 12.x]
1111
platform:
12-
- { os: windows-latest, hunspell: true }
12+
- { os: windows-latest, force-hunspell: true }
1313
- { os: windows-latest }
14-
- { os: macos-latest, hunspell: true }
14+
- { os: macos-latest, force-hunspell: true }
1515
- { os: macos-latest }
16-
- { os: ubuntu-latest }
16+
- { os: ubuntu-latest, use-clang: true }
1717

1818
runs-on: ${{ matrix.platform.os }}
19-
19+
env:
20+
SPELLCHECKER_PREFER_HUNSPELL: ${{ matrix.platform.hunspell }}
21+
2022
steps:
2123
- uses: actions/checkout@v1
2224
- name: Use Node.js ${{ matrix.node-version }}
2325
uses: actions/setup-node@v1
2426
with:
2527
node-version: ${{ matrix.node-version }}
28+
- name: npm install, build, and test (clang)
29+
if: matrix.platform.use-clang == true
30+
run: |
31+
export CC="$(which clang)"
32+
export CPP="$(which clang++)"
33+
npm install
34+
npm test
2635
- name: npm install, build, and test
2736
run: |
2837
npm install
2938
npm test
30-
env:
31-
SPELLCHECKER_PREFER_HUNSPELL: ${{ matrix.platform.hunspell }}

0 commit comments

Comments
 (0)