This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
fix(AWSSM): treat value as object iff the es specifies .property #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #73 for discussion.
JacopoDaeli
reviewed
Jun 1, 2019
lib/backends/kv-backend.js
Outdated
| parsedValue = JSON.parse(value) | ||
| } catch (err) { | ||
| this._logger.warn(`Failed to JSON.parse '${value}':`, err) | ||
| return undefined |
There was a problem hiding this comment.
no need to return undefined, just return this._logger.warn...) instead ?
There was a problem hiding this comment.
If we do that then this code takes a dependency on the return value of whatever logger we're using.
I'd rather have an additional line of code than an additional dependency on the return values of whatever logger we're using.
There was a problem hiding this comment.
Makes sense, can we just return then? undefined should be implicit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #73 for
discussion.