Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

fix(backends): fix secretsManager backend name #27

Merged
merged 2 commits into from
Mar 9, 2019
Merged

fix(backends): fix secretsManager backend name #27

merged 2 commits into from
Mar 9, 2019

Conversation

JacopoDaeli
Copy link
Contributor

@JacopoDaeli JacopoDaeli commented Mar 8, 2019 •
edited
Loading

NEED TO CREATE NEW DOCKER IMAGE AND SEPARATE PR TO UPDATE TAG IN DEPLOYMENT FILES.

@JacopoDaeli JacopoDaeli self-assigned this Mar 8, 2019
silasbw
silasbw reviewed Mar 8, 2019
View reviewed changes
Copy link
Contributor

@silasbw silasbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gosh, we'll need to update every ExternalSecret in use today before upgrading...Is there a way to make this backwards compatible?

@JacopoDaeli
Copy link
Contributor Author

JacopoDaeli commented Mar 8, 2019 •
edited
Loading

@silasbw yes, let's do that: https://github.com/godaddy/kubernetes-external-secrets/pull/27/files#diff-c8c5ee8e781f831e4927a392fa3565e6R42

Note: I kept that it is for backwards-compatibility well highlighted to avoid possible misunderstanding.

@JacopoDaeli JacopoDaeli merged commit d494edf into master Mar 9, 2019
@JacopoDaeli JacopoDaeli deleted the jdaeli/fixBkName0 branch March 9, 2019 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silasbw silasbw silasbw approved these changes

@satish-ravi satish-ravi Awaiting requested review from satish-ravi

Assignees

@JacopoDaeli JacopoDaeli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacopoDaeli @silasbw