Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

fix: iam role #179

Merged
merged 2 commits into from
Nov 5, 2019
Merged

fix: iam role #179

merged 2 commits into from
Nov 5, 2019

Conversation

moolen
Copy link
Member

@moolen moolen commented Oct 19, 2019

This PR fixes #174:

  • (bug) sync should work when namespace annotation is present, and no roleArn is provided
  • (feature) make the role-permission annotation key configurable

These issues are addressed in two separate commits.

Copy link
Member

@Flydiverny Flydiverny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moolen would you mind rebasing this? 😄

lib/poller.js Outdated Show resolved Hide resolved
@Flydiverny Flydiverny merged commit 8c17819 into external-secrets:master Nov 5, 2019
@moolen moolen deleted the fix/iam-role branch November 5, 2019 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of "iam.amazonaws.com/permitted" annotation causes conflicts with existing KIAM setups
2 participants