Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

feat: allow setting type in external secret to support other than Opaque secrets #130

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

Flydiverny
Copy link
Member

Possible solution for #109

Does this require anything more than being able to set type in the external secret resource?

Example:

apiVersion: kubernetes-client.io/v1
kind: ExternalSecret
metadata:
  name: my-dockerhub-secret
secretDescriptor:
  backendType: secretsManager
  type: kubernetes.io/dockerconfigjson
  data:
    - key: /development/mma/dockerhub
      name: .dockerconfigjson

Where the value in backend would be

{"auths":{"https://index.docker.io/v1/":{"auth":"bXljcmVkZW50aWFsczp2ZXJ5LW5pY2UtcGFzc3dvcmQ="}}}

Similarly could be done for tls?

apiVersion: kubernetes-client.io/v1
kind: ExternalSecret
metadata:
  name: my-tls
secretDescriptor:
  backendType: secretsManager
  type: kubernetes.io/tls
  data:
    - key: /development/mma/certifcate
      property: crt
      name: tls.crt
    - key: /development/mma/certifcate
      property: key
      name: tls.key

Originally posted by @Flydiverny in #109 (comment)

@Flydiverny
Copy link
Member Author

@silasbw @jeffpearce Please have a look :D

backendType: secretsManager
type: kubernetes.io/tls
data:
- key: /development/certifcate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda a nit, but

Suggested change
- key: /development/certifcate
- key: /development/certificate

- key: /development/certifcate
property: crt
name: tls.crt
- key: /development/certifcate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- key: /development/certifcate
- key: /development/certificate

@jeffpearce
Copy link
Contributor

Would you mind adding a test?

@Flydiverny
Copy link
Member Author

@jeffpearce test added and typo fixed 😄

Copy link
Contributor

@jeffpearce jeffpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Flydiverny !

@jeffpearce jeffpearce merged commit 226697a into external-secrets:master Jul 29, 2019
@eshamay
Copy link

eshamay commented Jul 29, 2019

I'm not familiar with the release process here, but I'm closely tracking this PR because I have immediate use for it. When is the next release (1.3.2 ?) expected to make it out?

@antoniotamer
Copy link

My team is eagerly awaiting this change as well, can we get an ETA on the next release?

Flydiverny added a commit to Flydiverny/kubernetes-external-secrets that referenced this pull request Nov 3, 2019
…que secrets (external-secrets#130)

* feat: allow setting type in external secret to support other than Opaque secrets
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants