Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISBAT consistenly apply styles within editor across versions #1604

Closed
4 tasks done
AnthonyLedesma opened this issue Jul 30, 2020 · 4 comments · Fixed by #1608
Closed
4 tasks done

ISBAT consistenly apply styles within editor across versions #1604

AnthonyLedesma opened this issue Jul 30, 2020 · 4 comments · Fixed by #1608
Assignees
Labels
[Priority] High This issue/pull request needs resolving before the next release [Type] Bug Something that is not working as expected
Milestone

Comments

@AnthonyLedesma
Copy link
Member

AnthonyLedesma commented Jul 30, 2020

Describe the bug:

CoBlocks uses CSS selectors which will soon deprecate with the release of WordPress 5.5. This need to deprecate is due to changes in markup within the editor. The specific selector which should be adjusted is .wp-block[data-type="*"] and can be located using Regex .wp-block\[.*?\].

At this time the selector in question can be found 137 times among 46 files including both .scss and .cypress.js files.

This PR: #1603 addresses a bug with the Media Card block that is directly related to changes in editor markup.

Isolating the problem:

  • This bug happens with no other plugins activated
  • This bug happens with a default WordPress theme active
  • This bug happens without the Gutenberg plugin active
  • I can reproduce this bug consistently using the steps above

WordPress version:

Happens with 5.5 WP ( OR 5.4.2 with Gutenberg active )

Gutenberg version:

8.5+ ( or Core 5.5 )

@AnthonyLedesma AnthonyLedesma added [Type] Bug Something that is not working as expected [Priority] High This issue/pull request needs resolving before the next release labels Jul 30, 2020
@richtabor
Copy link
Contributor

Could you give example of a selector that needs to be updated?

@richtabor
Copy link
Contributor

And is this only in the editor, or both?

@AnthonyLedesma
Copy link
Member Author

This effects editor styles only. Another example of a block that definitely needs to be addressed is the Shape Divider block.

.wp-block[data-type="coblocks/shape-divider"] {

This is the generated markup within the editor
image

The end result here is styles that do not take effect within the editor.

@richtabor richtabor added this to the Next Release milestone Aug 3, 2020
@richtabor
Copy link
Contributor

Ah, this is related to the light block wrapper efforts in core (which are causing other little display issues as well). Good find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High This issue/pull request needs resolving before the next release [Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants