From 3e27ec8f1f9abf8ecfd80c37d9581f9f19a1aa07 Mon Sep 17 00:00:00 2001 From: Sam Clark <3758302+goatgoose@users.noreply.github.com> Date: Tue, 17 Oct 2023 15:31:45 -0400 Subject: [PATCH] update integ test to expect TLS 1.3 --- tests/integrationv2/test_version_negotiation.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/integrationv2/test_version_negotiation.py b/tests/integrationv2/test_version_negotiation.py index 38c37ef51c3..7d25db0adea 100644 --- a/tests/integrationv2/test_version_negotiation.py +++ b/tests/integrationv2/test_version_negotiation.py @@ -77,12 +77,12 @@ def test_s2nc_tls13_negotiates_tls12(managed_process, cipher, curve, certificate for results in server.get_results(): results.assert_success() + # This check only cares about S2N. Trying to maintain expected output of other providers doesn't add benefit to + # whether the S2N client was able to negotiate a lower TLS version. if provider is S2N: - # The server is only TLS12, so it reads the version from the CLIENT_HELLO, which is never above TLS12 - # This check only cares about S2N. Trying to maintain expected output of other providers doesn't - # add benefit to whether the S2N client was able to negotiate a lower TLS version. + # The client sends a TLS 1.3 client hello so a client protocol version of TLS 1.3 should always be expected. assert to_bytes("Client protocol version: {}".format( - actual_version)) in results.stdout + Protocols.TLS13.value)) in results.stdout assert to_bytes("Actual protocol version: {}".format( actual_version)) in results.stdout