From 33bf1359390364444aebf75f46bc0dc85a575f35 Mon Sep 17 00:00:00 2001 From: davidvader Date: Mon, 26 Aug 2024 11:57:54 -0500 Subject: [PATCH] fix: remove unused var --- docker-compose.yml | 1 - tracing/flags.go | 8 +------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index b8d629cb0..f2ef7afbe 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -50,7 +50,6 @@ services: VELA_OTEL_TRACING_SERVICE_NAME: vela-server VELA_OTEL_TRACING_RESOURCE_ATTRIBUTES: "process.runtime.name=go" VELA_OTEL_TRACING_RESOURCE_ENV_ATTRIBUTES: "deployment.environment=CLOUD_ENVIRONMENT" - VELA_OTEL_TRACING_SAMPLER_RATIO: 1 VELA_OTEL_TRACING_SAMPLER_RATELIMIT_PER_SECOND: 0.2 env_file: - .env diff --git a/tracing/flags.go b/tracing/flags.go index 1dd3b6911..390d1a61e 100644 --- a/tracing/flags.go +++ b/tracing/flags.go @@ -71,16 +71,10 @@ var Flags = []cli.Flag{ Usage: "set otel sampler type attribute attached to each span.", Value: "sampler.type", }, - &cli.Float64Flag{ - EnvVars: []string{"VELA_OTEL_TRACING_SAMPLER_RATIO"}, - Name: "tracing.sampler.ratio", - Usage: "set otel tracing head-sampler acceptance ratio. see: https://opentelemetry.io/docs/concepts/sampling/", - Value: 0.5, - }, &cli.Float64Flag{ EnvVars: []string{"VELA_OTEL_TRACING_SAMPLER_RATELIMIT_PER_SECOND"}, Name: "tracing.sampler.persecond", Usage: "set otel tracing head-sampler rate-limiting to N per second. see: https://opentelemetry.io/docs/concepts/sampling/", - Value: 1, + Value: 0.2, }, }